Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cache size integer overflow #189

Merged
merged 2 commits into from
Sep 29, 2023
Merged

fix: cache size integer overflow #189

merged 2 commits into from
Sep 29, 2023

Conversation

dshemetov
Copy link
Contributor

@dshemetov dshemetov commented Sep 29, 2023 •
edited

fix #188

since the default for max_size in cache_disk is 1024 * 1024^2, a double, that argument can eat doubles, so remove the as.integer cast that's overflowing

dsweber2
dsweber2 approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@dsweber2 dsweber2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

who doesn't use 64bit integers...

@dsweber2 dsweber2 merged commit 2b48321 into dev Sep 29, 2023
@dsweber2 dsweber2 deleted the ds/cache-size branch September 29, 2023 23:04
@brookslogan brookslogan mentioned this pull request Oct 3, 2023
Closed
@dsweber2 dsweber2 added this to the Z: epidatr & epidatpy milestone Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsweber2 dsweber2 dsweber2 approved these changes

@brookslogan brookslogan Awaiting requested review from brookslogan brookslogan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Z: epidatr & epidatpy
Development

Successfully merging this pull request may close these issues.

Can't use a large cache size limit
2 participants
@dshemetov @dsweber2