Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If as_of sent to check_is_recent is a Date, compare to a Date threshold. #259

Merged
merged 4 commits into from
Feb 29, 2024

Conversation

nmdefries
Copy link
Contributor

@nmdefries nmdefries commented Feb 29, 2024

Checklist

Please:

  • Make sure this PR is against "dev", not "main" (unless this is a release
    PR).
  • Request a review from one of the current epidatr main reviewers:
    brookslogan, dshemetov, nmdefries, dsweber2.
  • Makes sure to bump the version number in DESCRIPTION. Always increment
    the patch version number (the third number), unless you are making a
    release PR from dev to main, in which case increment the minor version
    number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    1.7.2, then write your changes under the 1.8 heading).

Change explanations for reviewer

If as_of sent to check_is_recent is a Date, compare to a Date threshold.

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

Closes #258

Copy link
Contributor

@dsweber2 dsweber2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

NEWS.md Outdated Show resolved Hide resolved
Co-authored-by: David Weber <david.weber2@pm.me>
@nmdefries nmdefries merged commit a920a76 into dev Feb 29, 2024
8 checks passed
@nmdefries nmdefries deleted the ndefries/caching-asof-date branch February 29, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't use as_of = <Date> with caching enabled
2 participants