Probably don't want to drop the grouping in [.epi_df
when as_tibble()
is used
#145
Labels
question
Further information is requested
As per
[.epi_df
, when we subset anepi_df
so that the result is not a trueepi_df
anymore (ex. missingtime_value
orgeo_value
), then we return a tibble of the results (refer to around lines 102-104 of methods-epi_df.R). That seems ok, but a problem that arises is that if there is a grouping in the originalepi_df
, that grouping is lost when we useas_tibble()
. This issue showed up in the last two uses ofexpect_identical()
in tests-epi_slide.R. Ex. Inthe grouping by
geo_value
is lost when we usedplyr::select("geo_value","slide_value_value")
.Currently, we have decided to leave as is, but we may decide in the future that we should change this so the grouping is kept when
[.epi_df
is used.Tagged this as a question to keep it open for discussion.
The text was updated successfully, but these errors were encountered: