Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbind, vec_rbind, bind_rows give wrong metadata #242

Open
brookslogan opened this issue Nov 2, 2022 · 3 comments
Open

rbind, vec_rbind, bind_rows give wrong metadata #242

brookslogan opened this issue Nov 2, 2022 · 3 comments
Labels
bug Something isn't working P2 low priority

Comments

@brookslogan
Copy link
Contributor

These functions should:

  • check for a common other_keys else abort or do something smart
  • check for a common geo_type else use "custom"
  • check for a common time_type else use "custom"
  • use the max of the as_ofs
@brookslogan brookslogan added bug Something isn't working P2 low priority labels Nov 2, 2022
@brookslogan
Copy link
Contributor Author

Factors into #213.

@brookslogan
Copy link
Contributor Author

Alternatively, if the as_ofs differ, maybe we should degrade into a non-epi_df object, since it looks like we aren't using a single as_of. But this might not play well with the auto-as_of tagging (epi_dfs from the same script might get different as_ofs). It might require changing the default as_of to a sentinel value like "unspecified" or special class to express "unspecified; object created at ".

@brookslogan
Copy link
Contributor Author

A couple implementation paths:

  • Go ahead and validate geo_type in dplyr_reconstruct. Worry about performance cost.
  • Convert geo_values to factors or another special class when detected/specified as a particular type. Provide S3 methods that will automate degrading into another class. Have dplyr_reconstruct check for degradation.
  • Previous bullet point, but just remove geo_type from the epi_df altogether; have it tracked within the geo_value column.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2 low priority
Projects
None yet
Development

No branches or pull requests

1 participant