New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question about c2w #3
Comments
It's the same format as in the original NeRF paper for LLFF, which I think is "down, right, backwards" with the rotation matrix then reordered as in https://github.com/bmild/nerf/blob/master/load_llff.py#L250 So yes, the first dimension of the camera position is altitude, which goes downwards. |
So in this code, the rotation matrix is not reordered? |
The 'c2w' field in the metadata files in the provided datasets are already rotated with the operation in https://github.com/bmild/nerf/blob/master/load_llff.py#L250 - if you're using your own custom dataset you'll want to apply this operation before writing your metadata files |
Hmmmm I'm still confused. According to LLFF repo (https://github.com/Fyusion/LLFF#using-your-own-poses-without-running-colmap), before reordering, the three axes are [down, right, backwards], so I think after reordering it should be [right, up, backwards]? |
If 'c2w' in metadata is already reordered, should it be in order [right, up, backwards]? |
If you look at https://github.com/bmild/nerf/blob/master/load_llff.py#L250, you'll notice that the column reordering ends up becoming (1, -0, 2, 3), ie: drb -> rub for the rotation matrix. But the position itself (col 3), is unchanged, and is hence still in drb coordinates
|
Ahh I see. Thanks for your patience! |
Hi, just to confirm the format of c2w matrix. Is it c2w[:3,:3] corresponds to rot matrix in order [x,y,z] and c2w[:3,-1] the camera position in order [z,x,y]? I noticed in _truncate_with_plane_intersection you use rays_o[:, :, 0] < altitude.
The text was updated successfully, but these errors were encountered: