Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.17 API Update #3

Closed
cmccullough2 opened this issue Aug 24, 2016 · 16 comments
Closed

3.17 API Update #3

cmccullough2 opened this issue Aug 24, 2016 · 16 comments

Comments

@cmccullough2
Copy link

Will you be migrating this application to the 3.17 API in the near future?

@tmcgee
Copy link
Member

tmcgee commented Aug 24, 2016

@cmccullough2 I am using the 3.17 api without issue. This is in multiple apps for a couple of my clients.

@cmccullough2
Copy link
Author

Thank you. I am going to start my migration to 3.17.

@cmccullough2
Copy link
Author

3 17popupissue
For some reason when I moved to the 3.17 api, this image appeared in my viewer. I.E's Dom explorer is not giving me any clues. Have you seen this before?

@tmcgee
Copy link
Member

tmcgee commented Aug 25, 2016

I have not seen that before. The Chrome Dev Tools might be a better tool to inspect the DOM for additional clues.

@cmccullough2
Copy link
Author

Thanks. I am looking.

@tmcgee
Copy link
Member

tmcgee commented Aug 26, 2016

@cmccullough2 The repo has been updated to version 3.17 of the Esri JavaScript API. The latest update also provides support for version 2.1 of WebApp Builder.

@cmccullough2
Copy link
Author

Double thumbs up. Thanks

@cmccullough2
Copy link
Author

@tmcgee When you store the esri.css locally it breaks a bunch of images. I went into the css file and changed the location of images from ../dijit/images/{image} to ..images/{image} to repair the paths. I am a bit nervous about what this will do for future widget installs, etc. (the unknown). Just a thought.

@tmcgee
Copy link
Member

tmcgee commented Sep 1, 2016

Yes if you do not download the images, it would break due to the image paths in the css file. The most common practice for hosting locally is to download the entire JS API which includes everything. Is that not what you are doing?

@cmccullough2
Copy link
Author

cmccullough2 commented Sep 1, 2016

Yes, I am using the entire JS API. When I need to have the API off my work network I am hosting the API at this location, http://gissweetspot.com/arcgis_js_api/library/3.17/3.17/init.js. The location for the esri.css is here, ''. While I am at work, I have it at another location.

@tmcgee
Copy link
Member

tmcgee commented Sep 1, 2016

The path to your esri.css does not appear in your message above but I see in in the notification I receive.

I am not following why you have the esri css file under the cmv folder - a different location from the rest of the API. Are you making some customizations within it? If so, typically, you use the one in the API location and include your own custom css overrides in a separate css file like this

@cmccullough2
Copy link
Author

I have the esri.css in the cmv/css folder within the project. the JS API is outside. I am assuming I have to put the css someplace else??

@tmcgee
Copy link
Member

tmcgee commented Sep 1, 2016

I guess I don't understand why you have the esri.css separate from the JS API. If possible, you should try to keep the css file together with the API and then put any css customizations in a separate file within the project.

@cmccullough2
Copy link
Author

Ok, good advice. Under what folder in the api should the css reside.

@cmccullough2
Copy link
Author

Nevermind. That was a dumb question. I figured it out. I was making this harder than I needed to.

@tmcgee
Copy link
Member

tmcgee commented Sep 1, 2016

The file should already be included with the api however I see that it is not there on the gissweetspot.com server. That suggests that gissweetspot does not have a complete copy of the API (or I am missing something).

Obviously, I cannot see what you are using inside your network. When you are outside your network, can you use //js.arcgis.com/3.17/esri/css/esri.css and //js.arcgis.com/3.17/ instead of the gissweetspot.com?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants