Skip to content
This repository has been archived by the owner on Mar 19, 2019. It is now read-only.

Add search #19

Closed
dankohn opened this issue Jan 27, 2018 · 3 comments
Closed

Add search #19

dankohn opened this issue Jan 27, 2018 · 3 comments
Assignees
@AndreyKozlov1984
Labels
enhancement New feature or request
Projects
Kanban

Comments

@dankohn
Copy link
Contributor

dankohn commented Jan 27, 2018 •
edited
Loading

Search should be implemented as an additional filter that is combined (logical AND) with the other selected filters. The search items should be tokenized (separated on spaces, unless quotes are used) with each token shown as a separate chip. Chips should include an x to dismiss that search query. Search will be added in the URL and so the state can be shared.

See https://material.io/guidelines/components/chips.html#

Some tips on designing search.
@dankohn dankohn added the enhancement New feature or request label Jan 27, 2018
@dankohn dankohn added this to the soon milestone Jan 27, 2018
@dankohn dankohn added this to Soon in Kanban via automation Jan 27, 2018
@dankohn dankohn modified the milestones: soon, later Feb 2, 2018
@AndreyKozlov1984 AndreyKozlov1984 moved this from Soon to In progress in Kanban Feb 3, 2018
@AndreyKozlov1984
Copy link
Collaborator

Quite interesting how this will be better than Ctrl+F or Cmd+F. I already use it to quickly look for a given tile.

@AndreyKozlov1984 AndreyKozlov1984 moved this from In progress to Soon in Kanban Feb 3, 2018
@dankohn
Copy link
Contributor Author

dankohn commented Feb 3, 2018

Search will be added in the URL and so the state can be shared.

@dankohn dankohn removed this from the later milestone Feb 4, 2018
@dankohn dankohn moved this from Soon to Later in Kanban Feb 4, 2018
@dankohn dankohn mentioned this issue Mar 2, 2018
Closed
@dankohn
Copy link
Contributor Author

dankohn commented Mar 2, 2018

Kamino closed and cloned this issue to cncf/landscape

@dankohn dankohn closed this as completed Mar 2, 2018
Kanban automation moved this from Later to Done Mar 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AndreyKozlov1984 AndreyKozlov1984

Labels
enhancement New feature or request
Projects
Kanban
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AndreyKozlov1984 @dankohn