Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't install on macOS Catalina #475

Closed
dankohn opened this issue Nov 30, 2019 · 2 comments
Closed

Can't install on macOS Catalina #475

dankohn opened this issue Nov 30, 2019 · 2 comments
Labels
bug Something isn't working
Projects

Comments

@dankohn
Copy link
Contributor

dankohn commented Nov 30, 2019

Can you please help me debug this?

Dans-MacBook-Pro:landscapeapp (master)$ npm install sharp

> sharp@0.22.1 install /Users/dan/Dropbox/Documents/dev/landscapeapp/node_modules/favicons/node_modules/sharp
> (node install/libvips && node install/dll-copy && prebuild-install) || (node-gyp rebuild && node install/dll-copy)

info sharp Using cached /Users/dan/.npm/_libvips/libvips-8.7.4-darwin-x64.tar.gz
prebuild-install WARN install No prebuilt binaries found (target=13.2.0 runtime=node arch=x64 libc= platform=darwin)
  TOUCH Release/obj.target/libvips-cpp.stamp
  CXX(target) Release/obj.target/sharp/src/common.o
  CXX(target) Release/obj.target/sharp/src/metadata.o
  CXX(target) Release/obj.target/sharp/src/stats.o
../src/stats.cc:130:19: error: no matching member function for call to 'Set'
        channels->Set(i, channelStat);
        ~~~~~~~~~~^~~
/Users/dan/Library/Caches/node-gyp/13.2.0/include/node/v8.h:3547:37: note: candidate function not viable: requires 3 arguments, but 2 were provided
  V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context,
                                    ^
/Users/dan/Library/Caches/node-gyp/13.2.0/include/node/v8.h:3550:37: note: candidate function not viable: requires 3 arguments, but 2 were provided
  V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context, uint32_t index,
                                    ^
1 error generated.
make: *** [Release/obj.target/sharp/src/stats.o] Error 1
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/npm-lifecycle/node_modules/node-gyp/lib/build.js:194:23)
gyp ERR! stack     at ChildProcess.emit (events.js:210:5)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:270:12)
gyp ERR! System Darwin 19.0.0
gyp ERR! command "/usr/local/Cellar/node/13.2.0/bin/node" "/usr/local/lib/node_modules/npm/node_modules/npm-lifecycle/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/dan/Dropbox/Documents/dev/landscapeapp/node_modules/favicons/node_modules/sharp
gyp ERR! node -v v13.2.0
gyp ERR! node-gyp -v v5.0.5
gyp ERR! not ok 
npm WARN jest-puppeteer@4.3.0 requires a peer of puppeteer@^1.5.0 but none is installed. You must install peer dependencies yourself.

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! sharp@0.22.1 install: `(node install/libvips && node install/dll-copy && prebuild-install) || (node-gyp rebuild && node install/dll-copy)`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the sharp@0.22.1 install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/dan/.npm/_logs/2019-11-30T18_32_11_168Z-debug.log
Dans-MacBook-Pro:landscapeapp (master)$ 
@dankohn dankohn added the bug Something isn't working label Nov 30, 2019
@dankohn dankohn added this to Triage in interactive via automation Nov 30, 2019
@dankohn dankohn moved this from Triage to Soon in interactive Nov 30, 2019
@dankohn
Copy link
Contributor Author

dankohn commented Dec 1, 2019

It looks like the problem is that an old version of sharp (not supported on macOS Catalina) is being used by favicons which is being called by webapp-webpack-plugin which has been deprecated. They now recommend favicon-webpack-plugin instead.

Could you please switch to that. https://www.npmjs.com/package/webapp-webpack-plugin

@dankohn
Copy link
Contributor Author

dankohn commented Dec 1, 2019

Closing in favor of other issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
interactive
  
Done
Development

No branches or pull requests

1 participant