Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments on M0/M6 command not working in gcode #760

Closed
4 of 12 tasks
wb9tpg opened this issue May 17, 2022 · 5 comments · Fixed by #768
Closed
4 of 12 tasks

Comments on M0/M6 command not working in gcode #760

wb9tpg opened this issue May 17, 2022 · 5 comments · Fixed by #768
Assignees
@cheton
Labels
focus:gcode focus:macros Grbl hw:raspberry-pi install:npm

Comments

@wb9tpg
Copy link

wb9tpg commented May 17, 2022

Description

I've manually created a simple gcode file

G0 X0Y0
M0;Say Something
G0 X10Y10

The M command comment does not display when running the gcode from a file but it will display if I place the same gcode in a macro. I seems it's supposed to work in both test cases based in the description in the release.

Versions

  • CNCjs: 1.9.25
  • Node.js: 10.24.1
  • NPM: 6.14.12

How Do You Install CNCjs?

  • NPM
  • Download the CNCjs Desktop Application

CNC Controller

  • Grbl
  • Smoothieware
  • TinyG/g2core

Hardware

  • Raspberry Pi
  • Desktop or Laptop
  • Mobile Device

Operating System

  • Not Applicable
  • Windows
  • Mac
  • Linux
@Bart95580
Copy link

same issue for me.
It's not working from gcode file.
so, it's not useful :-(

@cheton cheton linked a pull request Jun 21, 2022 that will close this issue
feat: display the G-code line of certain M commands (e.g. M0/M1/M6/...) in the toast notification #768
Merged
@cheton
Copy link
Collaborator

cheton commented Jun 21, 2022

@wb9tpg @Bart95580 PR #768 will add support for displaying the comment of M0/M1/M2/M30/M6/M109/M190 commands.

@cheton cheton self-assigned this Jun 21, 2022
@cheton
Copy link
Collaborator

cheton commented Jun 22, 2022 •
edited

@wb9tpg @Bart9558
Published v1.9.26

@Bart95580
Copy link

Thank you very much
My first test with M06 command is successful

@wb9tpg
Copy link
Author

wb9tpg commented Jul 29, 2022

Tested this today and it passed all my tests. Thanks for the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cheton cheton

Labels
focus:gcode focus:macros Grbl hw:raspberry-pi install:npm
Projects
None yet
Milestone
No milestone
4 participants
@cheton @emcniece @wb9tpg @Bart95580