Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French console output instead of english #276

Closed
marcowork opened this issue Aug 23, 2021 · 2 comments · Fixed by #278 or #279
Closed

French console output instead of english #276

marcowork opened this issue Aug 23, 2021 · 2 comments · Fixed by #278 or #279
Labels
bug Something isn't working done This issue was solved but not merged in master question Further information is requested
Milestone

Comments

@marcowork
Copy link

Guys,

in this file:
Sonar-cnes-report/src/main/java/fr/cnes/sonar/report/exporters/ConsoleExporter.java

Line 66 is French console output. Shouldn't this be english?

@marcowork marcowork added the question Further information is requested label Aug 23, 2021
@marcowork
Copy link
Author

    // log number of issues
    message = String.format("Nombre total de violations : %s", issues.size());
    LOGGER.info(message);

I think it should be

    // log number of issues
    message = String.format("Total number of violations : %s", issues.size());
    LOGGER.info(message);

@Sancretor
Copy link
Contributor

Hi @marcowork

Thanks a lot for your feedback !
Well, I'll look into it but I'm not surprised we still find these french sentences...
Honestly, the language selector feature has never been fully finished.
We'll fix this issue for the next release anyway.
Thanks !

@Sancretor Sancretor added this to the 4.0.0 milestone Aug 23, 2021
@Sancretor Sancretor added the bug Something isn't working label Aug 23, 2021
@Sancretor Sancretor linked a pull request Aug 27, 2021 that will close this issue
12 tasks
@Sancretor Sancretor added the done This issue was solved but not merged in master label Aug 27, 2021
@Sancretor Sancretor mentioned this issue Aug 27, 2021
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working done This issue was solved but not merged in master question Further information is requested
Projects
None yet
2 participants