Fixing incorrect buffer in WideCharToMultiByte call in wc2mb (charset.cpp) #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for fixing this issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
form.icon()did not work properly under MinGW - long story short, turns out that the WideCharToMultiByte call got an incorrectcbMultiByteparameter - thus returned anERROR_INSUFFICIENT_BUFFERerror.mbstr.resize(bytes - 1);is correct - that is counted without the terminating zero.cbMultiByte, however is "Size, in bytes, of the buffer indicated by lpMultiByteStr." so the terminating zero must be counted too.I am not sure how to proceed with adding checks for all return values of all of the
Stringapiset.hcalls here, so I'll leave that for later. Ideallywc2mbshould have failed though.