Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Store data that dropped by DROP TABLE command #1178

Closed
zipper-meng opened this issue May 12, 2023 · 2 comments
Closed

[Feature] Store data that dropped by DROP TABLE command #1178

zipper-meng opened this issue May 12, 2023 · 2 comments
Assignees
@zipper-meng
Labels
kv store
Milestone
2.3.2

Comments

@zipper-meng
Copy link
Member

Is your feature request related to a problem? Please describe.

Bug: Cache data removed by dropping the table recovered after restart.

This is because the DROP TABLE command deleted the cache but the data is still in WAL, so it caused.

Describe the solution you'd like

DROP TABLE execution will create WAL entries when deleting data in memory caches, after successfully wrote them to WAL, do the memory cache deletes.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.
@roseboy-liu
Copy link
Contributor

  • drop vnode

@zipper-meng zipper-meng mentioned this issue Jul 10, 2023
Merged
4 tasks
@roseboy-liu roseboy-liu modified the milestones: Long Term, 2.3.2 Jul 10, 2023
@zipper-meng
Copy link
Member Author

A bug fix: #1363

@h4ofanya h4ofanya mentioned this issue Feb 1, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zipper-meng zipper-meng

Labels
kv store
Projects
None yet
Milestone
2.3.2
Development

No branches or pull requests
2 participants
@zipper-meng @roseboy-liu