Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix premature end of SigGen iteration #7

Open
gabrielbrunheira opened this issue Apr 25, 2022 · 0 comments
Open

Fix premature end of SigGen iteration #7

gabrielbrunheira opened this issue Apr 25, 2022 · 0 comments
Labels
bug

Comments

@gabrielbrunheira
Copy link
Contributor

gabrielbrunheira commented Apr 25, 2022 •
edited
Loading

Current implementation disables SigGen before iteration index n reaches the number of iterations initialized aux_var[2].

For instance, line 351 from run_siggen_sine() function:

https://github.com/cnpem-sei/udc-dsp-fw/blob/17a7e0ec598be77d2b7edc9f21ca4303a5c70f32/elp_libs/siggen/siggen.c#L345-L358

This stops the generated signal one iteration earlier, resulting in a final value different from expected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gabrielbrunheira