feat: add EDGEDRIVER_CDNURL env #50
Conversation
cnpm/cnpmcore#594 ```bash EDGEDRIVER_CDNURL=https://npmmirror.com/mirrors/edgedriver EDGEDRIVER_VERSION=126.0.2578.0 npx edgedriver -v ```
WalkthroughThe recent updates refine Node.js workflows by adding a new version and streamlining the release process. The repository is kept clean with the exclusion of Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- .github/workflows/nodejs.yml (1 hunks)
- .github/workflows/release.yml (1 hunks)
- .gitignore (1 hunks)
- README.md (1 hunks)
- package.json (1 hunks)
Files skipped from review due to trivial changes (2)
- .github/workflows/release.yml
- .gitignore
Additional Context Used
LanguageTool (4)
README.md (4)
Near line 16: Unpaired symbol: ‘]’ seems to be missing
Context: ...ps://github.com/mafintosh/prebuild) and [node-pre-gyp](https://github.com/mapbox/...
Near line 33: Unpaired symbol: ‘]’ seems to be missing
Context: ...ub>](https://github.com/elrrrrrrr)
|[<img src="https://avatars.githubusercont...
Near line 35: It appears that a hyphen is missing (if ‘auto’ is not used in the context of ‘cars’).
Context: ...//github.com/xudafeng/git-contributor), auto updated atSat May 11 2024 21:19:34 GMT+0800....
Near line 35: Commas set off the year in a month-day-year date.
Context: ...afeng/git-contributor), auto updated atSat May 11 2024 21:19:34 GMT+0800. <!-- GITCONTR...
Additional comments not posted (1)
.github/workflows/nodejs.yml (1)
15-15: Ensure compatibility of Node.js version 22 with the tools used in this workflow.
| @@ -28,10 +28,10 @@ Binary mirror config for [prebuild](https://github.com/mafintosh/prebuild) and [ | |||
|
|
|||
| ## Contributors | |||
|
|
|||
| |[<img src="https://avatars.githubusercontent.com/u/156269?v=4" width="100px;"/><br/><sub><b>fengmk2</b></sub>](https://github.com/fengmk2)<br/>|[<img src="https://avatars.githubusercontent.com/u/4635838?v=4" width="100px;"/><br/><sub><b>gemwuu</b></sub>](https://github.com/gemwuu)<br/>|[<img src="https://avatars.githubusercontent.com/u/6897780?v=4" width="100px;"/><br/><sub><b>killagu</b></sub>](https://github.com/killagu)<br/>|[<img src="https://avatars.githubusercontent.com/u/1119126?v=4" width="100px;"/><br/><sub><b>looksgood</b></sub>](https://github.com/looksgood)<br/>|[<img src="https://avatars.githubusercontent.com/u/36290410?v=4" width="100px;"/><br/><sub><b>WEN-JY</b></sub>](https://github.com/WEN-JY)<br/>|[<img src="https://avatars.githubusercontent.com/u/4136679?v=4" width="100px;"/><br/><sub><b>yibn2008</b></sub>](https://github.com/yibn2008)<br/>| | |||
| |[<img src="https://avatars.githubusercontent.com/u/156269?v=4" width="100px;"/><br/><sub><b>fengmk2</b></sub>](https://github.com/fengmk2)<br/>|[<img src="https://avatars.githubusercontent.com/u/4635838?v=4" width="100px;"/><br/><sub><b>gemwuu</b></sub>](https://github.com/gemwuu)<br/>|[<img src="https://avatars.githubusercontent.com/u/32174276?v=4" width="100px;"/><br/><sub><b>semantic-release-bot</b></sub>](https://github.com/semantic-release-bot)<br/>|[<img src="https://avatars.githubusercontent.com/u/6897780?v=4" width="100px;"/><br/><sub><b>killagu</b></sub>](https://github.com/killagu)<br/>|[<img src="https://avatars.githubusercontent.com/u/1119126?v=4" width="100px;"/><br/><sub><b>looksgood</b></sub>](https://github.com/looksgood)<br/>|[<img src="https://avatars.githubusercontent.com/u/36290410?v=4" width="100px;"/><br/><sub><b>WEN-JY</b></sub>](https://github.com/WEN-JY)<br/>| | |||
There was a problem hiding this comment.
Add alt text for contributor images to improve accessibility.
- [<img src="https://avatars.githubusercontent.com/u/156269?v=4" width="100px;"/><br/><sub><b>fengmk2</b></sub>](https://github.com/fengmk2)<br/>
+ [<img src="https://avatars.githubusercontent.com/u/156269?v=4" alt="fengmk2" width="100px;"/><br/><sub><b>fengmk2</b></sub>](https://github.com/fengmk2)<br/>Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| |[<img src="https://avatars.githubusercontent.com/u/156269?v=4" width="100px;"/><br/><sub><b>fengmk2</b></sub>](https://github.com/fengmk2)<br/>|[<img src="https://avatars.githubusercontent.com/u/4635838?v=4" width="100px;"/><br/><sub><b>gemwuu</b></sub>](https://github.com/gemwuu)<br/>|[<img src="https://avatars.githubusercontent.com/u/32174276?v=4" width="100px;"/><br/><sub><b>semantic-release-bot</b></sub>](https://github.com/semantic-release-bot)<br/>|[<img src="https://avatars.githubusercontent.com/u/6897780?v=4" width="100px;"/><br/><sub><b>killagu</b></sub>](https://github.com/killagu)<br/>|[<img src="https://avatars.githubusercontent.com/u/1119126?v=4" width="100px;"/><br/><sub><b>looksgood</b></sub>](https://github.com/looksgood)<br/>|[<img src="https://avatars.githubusercontent.com/u/36290410?v=4" width="100px;"/><br/><sub><b>WEN-JY</b></sub>](https://github.com/WEN-JY)<br/>| | |
| |[<img src="https://avatars.githubusercontent.com/u/156269?v=4" alt="fengmk2" width="100px;"/><br/><sub><b>fengmk2</b></sub>](https://github.com/fengmk2)<br/>|[<img src="https://avatars.githubusercontent.com/u/4635838?v=4" width="100px;"/><br/><sub><b>gemwuu</b></sub>](https://github.com/gemwuu)<br/>|[<img src="https://avatars.githubusercontent.com/u/32174276?v=4" width="100px;"/><br/><sub><b>semantic-release-bot</b></sub>](https://github.com/semantic-release-bot)<br/>|[<img src="https://avatars.githubusercontent.com/u/6897780?v=4" width="100px;"/><br/><sub><b>killagu</b></sub>](https://github.com/killagu)<br/>|[<img src="https://avatars.githubusercontent.com/u/1119126?v=4" width="100px;"/><br/><sub><b>looksgood</b></sub>](https://github.com/looksgood)<br/>|[<img src="https://avatars.githubusercontent.com/u/36290410?v=4" width="100px;"/><br/><sub><b>WEN-JY</b></sub>](https://github.com/WEN-JY)<br/>| |
| | :---: | :---: | :---: | :---: | :---: | :---: | | ||
| [<img src="https://avatars.githubusercontent.com/u/985607?v=4" width="100px;"/><br/><sub><b>dead-horse</b></sub>](https://github.com/dead-horse)<br/>|[<img src="https://avatars.githubusercontent.com/u/2784308?v=4" width="100px;"/><br/><sub><b>yisibl</b></sub>](https://github.com/yisibl)<br/> | ||
| [<img src="https://avatars.githubusercontent.com/u/6996341?v=4" width="100px;"/><br/><sub><b>yuler</b></sub>](https://github.com/yuler)<br/>|[<img src="https://avatars.githubusercontent.com/u/4136679?v=4" width="100px;"/><br/><sub><b>yibn2008</b></sub>](https://github.com/yibn2008)<br/>|[<img src="https://avatars.githubusercontent.com/u/985607?v=4" width="100px;"/><br/><sub><b>dead-horse</b></sub>](https://github.com/dead-horse)<br/>|[<img src="https://avatars.githubusercontent.com/u/5574625?v=4" width="100px;"/><br/><sub><b>elrrrrrrr</b></sub>](https://github.com/elrrrrrrr)<br/>|[<img src="https://avatars.githubusercontent.com/u/2784308?v=4" width="100px;"/><br/><sub><b>yisibl</b></sub>](https://github.com/yisibl)<br/> |
There was a problem hiding this comment.
Fix table formatting by ensuring proper use of leading and trailing pipes.
- |[<img src="https://avatars.githubusercontent.com/u/6996341?v=4" width="100px;"/><br/><sub><b>yuler</b></sub>](https://github.com/yuler)<br/>|[<img src="https://avatars.githubusercontent.com/u/4136679?v=4" width="100px;"/><br/><sub><b>yibn2008</b></sub>](https://github.com/yibn2008)<br/>|
+ |[<img src="https://avatars.githubusercontent.com/u/6996341?v=4" width="100px;"/><br/><sub><b>yuler</b></sub>](https://github.com/yuler)|[<img src="https://avatars.githubusercontent.com/u/4136679?v=4" width="100px;"/><br/><sub><b>yibn2008</b></sub>](https://github.com/yibn2008)|Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| [<img src="https://avatars.githubusercontent.com/u/6996341?v=4" width="100px;"/><br/><sub><b>yuler</b></sub>](https://github.com/yuler)<br/>|[<img src="https://avatars.githubusercontent.com/u/4136679?v=4" width="100px;"/><br/><sub><b>yibn2008</b></sub>](https://github.com/yibn2008)<br/>|[<img src="https://avatars.githubusercontent.com/u/985607?v=4" width="100px;"/><br/><sub><b>dead-horse</b></sub>](https://github.com/dead-horse)<br/>|[<img src="https://avatars.githubusercontent.com/u/5574625?v=4" width="100px;"/><br/><sub><b>elrrrrrrr</b></sub>](https://github.com/elrrrrrrr)<br/>|[<img src="https://avatars.githubusercontent.com/u/2784308?v=4" width="100px;"/><br/><sub><b>yisibl</b></sub>](https://github.com/yisibl)<br/> | |
| |[<img src="https://avatars.githubusercontent.com/u/6996341?v=4" width="100px;"/><br/><sub><b>yuler</b></sub>](https://github.com/yuler)|[<img src="https://avatars.githubusercontent.com/u/4136679?v=4" width="100px;"/><br/><sub><b>yibn2008</b></sub>](https://github.com/yibn2008)|[<img src="https://avatars.githubusercontent.com/u/985607?v=4" width="100px;"/><br/><sub><b>dead-horse</b></sub>](https://github.com/dead-horse)|[<img src="https://avatars.githubusercontent.com/u/5574625?v=4" width="100px;"/><br/><sub><b>elrrrrrrr</b></sub>](https://github.com/elrrrrrrr)|[<img src="https://avatars.githubusercontent.com/u/2784308?v=4" width="100px;"/><br/><sub><b>yisibl</b></sub>](https://github.com/yisibl)| |
|
|
||
| This project follows the git-contributor [spec](https://github.com/xudafeng/git-contributor), auto updated at `Thu Aug 25 2022 07:53:47 GMT+0800`. | ||
| This project follows the git-contributor [spec](https://github.com/xudafeng/git-contributor), auto updated at `Sat May 11 2024 21:19:34 GMT+0800`. |
There was a problem hiding this comment.
Correct the timestamp format by adding a comma after the day.
- auto updated at `Sat May 11 2024 21:19:34 GMT+0800`.
+ auto updated at `Sat May 11, 2024 21:19:34 GMT+0800`.Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| This project follows the git-contributor [spec](https://github.com/xudafeng/git-contributor), auto updated at `Sat May 11 2024 21:19:34 GMT+0800`. | |
| This project follows the git-contributor [spec](https://github.com/xudafeng/git-contributor), auto updated at `Sat May 11, 2024 21:19:34 GMT+0800`. |
package.json
Outdated
| @@ -47,6 +47,7 @@ | |||
| "china": { | |||
| "ENVS": { | |||
| "COREPACK_NPM_REGISTRY": "https://registry.npmmirror.com", | |||
| "EDGEDRIVER_CDNURL": "https://npmmirror.com/mirrors/edgedriver", | |||
There was a problem hiding this comment.
Tip
Codebase Verification
The verification process has revealed that the redirected URL https://cdn.npmmirror.com/binaries/edgedriver results in a HTTP 404 error, indicating that the resource could not be found. This suggests that either the URL is incorrect or the resource is not available at the specified location. It is recommended to review and correct the EDGEDRIVER_CDNURL to ensure it points to a valid and accessible resource.
- Check and update the
EDGEDRIVER_CDNURLin thepackage.jsonto a valid URL where the Edge Driver binaries are available.
Analysis chain
Verify the availability and correctness of the EDGEDRIVER_CDNURL.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the availability and correctness of the `EDGEDRIVER_CDNURL`.
# Test: Check if the URL is reachable and correct.
curl -I https://npmmirror.com/mirrors/edgedriver
Length of output: 668
Script:
#!/bin/bash
# Description: Verify the availability and correctness of the redirected `EDGEDRIVER_CDNURL`.
# Test: Check if the redirected URL is reachable and correct.
curl -I https://cdn.npmmirror.com/binaries/edgedriver
Length of output: 1107
There was a problem hiding this comment.
Actionable comments posted: 1
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- test/index.test.js (3 hunks)
Additional comments not posted (2)
test/index.test.js (2)
231-231: Ensure consistency in the URL format forEDGEDRIVER_CDNURL.Refer to the previous comment regarding the URL format for
EDGEDRIVER_CDNURL.
309-309: Ensure consistency in the URL format forEDGEDRIVER_CDNURL.Refer to the previous comment regarding the URL format for
EDGEDRIVER_CDNURL.
| @@ -154,6 +154,7 @@ describe('test/index.test.js', () => { | |||
| assert.deepStrictEqual(options, { | |||
| env: { | |||
| NODEJS_ORG_MIRROR: 'https://cdn.npmmirror.com/binaries/node', | |||
| EDGEDRIVER_CDNURL: 'https://npmmirror.com/mirrors/edgedriver', | |||
There was a problem hiding this comment.
Ensure consistency in the URL format for EDGEDRIVER_CDNURL.
- EDGEDRIVER_CDNURL: 'https://npmmirror.com/mirrors/edgedriver',
+ EDGEDRIVER_CDNURL: 'https://cdn.npmmirror.com/mirrors/edgedriver',The URL for EDGEDRIVER_CDNURL should match the format used for other CDN URLs in the project, which typically start with https://cdn.npmmirror.com. This change will ensure consistency across all environment variables.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| EDGEDRIVER_CDNURL: 'https://npmmirror.com/mirrors/edgedriver', | |
| EDGEDRIVER_CDNURL: 'https://cdn.npmmirror.com/mirrors/edgedriver', |
[skip ci] ## [2.14.0](v2.13.0...v2.14.0) (2024-05-11) ### Features * add EDGEDRIVER_CDNURL env ([#50](#50)) ([b14b16a](b14b16a))
cnpm/cnpmcore#594
Summary by CodeRabbit
Chores
Documentation
New Features