feat: update playwright config #681
Conversation
WalkthroughThe recent updates to Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- app/common/adapter/binary/PlaywrightBinary.ts (7 hunks)
- test/common/adapter/binary/PlaywrightBinary.test.ts (1 hunks)
Additional comments not posted (19)
app/common/adapter/binary/PlaywrightBinary.ts (19)
16-19: Remove unsupportedubuntu18.04paths.The removal of
ubuntu18.04paths forchromiumis appropriate as it aligns with the updated support matrix.
22-24: Update paths fordebian11anddebian12.The updated paths for
debian11anddebian12forchromiumare correct and align with the new structure.
35-36: Add support formac14andmac14-arm64.The addition of
mac14andmac14-arm64paths forchromiumis correct and aligns with the new support matrix.
41-44: Remove unsupportedubuntu18.04paths.The removal of
ubuntu18.04paths forchromium-tip-of-treeis appropriate as it aligns with the updated support matrix.
47-49: Update paths fordebian11anddebian12.The updated paths for
debian11anddebian12forchromium-tip-of-treeare correct and align with the new structure.
60-61: Add support formac14andmac14-arm64.The addition of
mac14andmac14-arm64paths forchromium-tip-of-treeis correct and aligns with the new support matrix.
66-68: Remove unsupportedubuntu18.04paths.The removal of
ubuntu18.04paths forfirefoxis appropriate as it aligns with the updated support matrix.
72-75: Update paths fordebian11anddebian12.The updated paths for
debian11anddebian12forfirefoxare correct and align with the new structure.
85-86: Add support formac14andmac14-arm64.The addition of
mac14andmac14-arm64paths forfirefoxis correct and aligns with the new support matrix.
91-93: Remove unsupportedubuntu18.04paths.The removal of
ubuntu18.04paths forfirefox-betais appropriate as it aligns with the updated support matrix.
97-100: Update paths fordebian11anddebian12.The updated paths for
debian11anddebian12forfirefox-betaare correct and align with the new structure.
110-111: Add support formac14andmac14-arm64.The addition of
mac14andmac14-arm64paths forfirefox-betais correct and aligns with the new support matrix.
116-118: Remove unsupportedubuntu18.04paths.The removal of
ubuntu18.04paths forwebkitis appropriate as it aligns with the updated support matrix.
122-125: Update paths fordebian11anddebian12.The updated paths for
debian11anddebian12forwebkitare correct and align with the new structure.
135-136: Add support formac14andmac14-arm64.The addition of
mac14andmac14-arm64paths forwebkitis correct and aligns with the new support matrix.
141-143: Remove unsupportedubuntu18.04paths.The removal of
ubuntu18.04paths forffmpegis appropriate as it aligns with the updated support matrix.
147-149: Update paths fordebian11anddebian12.The updated paths for
debian11anddebian12forffmpegare correct and align with the new structure.
160-161: Add support formac14andmac14-arm64.The addition of
mac14andmac14-arm64paths forffmpegis correct and aligns with the new support matrix.
166-187: Add support forandroidpaths.The addition of
androidpaths for various platforms is correct and aligns with the new support matrix.
| @@ -51,19 +51,18 @@ describe('test/common/adapter/binary/PlaywrightBinary.test.ts', () => { | |||
| let result = await binary.fetch('/builds/'); | |||
| assert(result); | |||
| // console.log(result.items); | |||
| assert.equal(result.items.length, 8); | |||
| assert.equal(result.items.length, 7); | |||
There was a problem hiding this comment.
Update the expected length of result.items.
The expected length of result.items should be updated to 6 instead of 7, as the chromium-with-symbols configuration has been removed.
- assert.equal(result.items.length, 7);
+ assert.equal(result.items.length, 6);Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| assert.equal(result.items.length, 7); | |
| assert.equal(result.items.length, 6); |
| assert.equal(result.items[2].name, 'firefox/'); | ||
| assert.equal(result.items[3].name, 'firefox-beta/'); | ||
| assert.equal(result.items[4].name, 'webkit/'); | ||
| assert.equal(result.items[5].name, 'ffmpeg/'); | ||
| assert.equal(result.items[6].name, 'android/'); |
There was a problem hiding this comment.
Update the expected item names and their order.
The expected item names and their order should be updated to reflect the removal of chromium-with-symbols and the addition of android.
- assert.equal(result.items[0].name, 'chromium/');
- assert.equal(result.items[1].name, 'chromium-tip-of-tree/');
- assert.equal(result.items[2].name, 'firefox/');
- assert.equal(result.items[3].name, 'firefox-beta/');
- assert.equal(result.items[4].name, 'webkit/');
- assert.equal(result.items[5].name, 'ffmpeg/');
- assert.equal(result.items[6].name, 'android/');
+ assert.equal(result.items[0].name, 'firefox/');
+ assert.equal(result.items[1].name, 'firefox-beta/');
+ assert.equal(result.items[2].name, 'webkit/');
+ assert.equal(result.items[3].name, 'ffmpeg/');
+ assert.equal(result.items[4].name, 'android/');Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| assert.equal(result.items[2].name, 'firefox/'); | |
| assert.equal(result.items[3].name, 'firefox-beta/'); | |
| assert.equal(result.items[4].name, 'webkit/'); | |
| assert.equal(result.items[5].name, 'ffmpeg/'); | |
| assert.equal(result.items[6].name, 'android/'); | |
| assert.equal(result.items[0].name, 'firefox/'); | |
| assert.equal(result.items[1].name, 'firefox-beta/'); | |
| assert.equal(result.items[2].name, 'webkit/'); | |
| assert.equal(result.items[3].name, 'ffmpeg/'); | |
| assert.equal(result.items[4].name, 'android/'); |
[skip ci] ## [3.57.0](v3.56.2...v3.57.0) (2024-05-14) ### Features * update playwright config ([#681](#681)) ([6bfbe35](6bfbe35))
DOWNLOAD_PATHSconfigurationandroidrelated configurationchromium-with-symbolsconfiguration andubuntu18.04related versionsDOWNLOAD_PATHS相关配置android相关配置chromium-with-symbols配置，ubuntu18.04相关版本Summary by CodeRabbit
New Features
mac14andmac14-arm64platforms for Chromium and Chromium tip-of-tree downloads.Bug Fixes
Tests