Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working on repo with commit hash #51

Closed
livelazily opened this issue Mar 12, 2016 · 7 comments · Fixed by #54
Closed

Not working on repo with commit hash #51

livelazily opened this issue Mar 12, 2016 · 7 comments · Fixed by #54

Comments

@livelazily
Copy link

Sample package.json:

{
  "name": "test_hash",
  "dependencies": {
    "grunt-cli": "gruntjs/grunt-cli#121f282"
  }
}
@dead-horse
Copy link
Member

支持这种模式会导致所有从 git 安装都会很慢(因为要 clone 整个项目才能找到这个 commit),而且从 git 的一个 commit 安装也很不靠谱,所以 npminstall 暂时不会去对这个做支持

@livelazily
Copy link
Author

可否使用 github 的 api 直接下载指定 commit 的 archive:
https://github.com/foo/bar/archive/commit-hash.zip

这样就不用下载整个 repo 了
因为使用这种依赖的大都不是自己直接使用, 而是依赖树上的某个包, 偶尔引用某个包时就会踩坑了

@dead-horse
Copy link
Member

@dead-horse
Copy link
Member

#52

@livelazily
Copy link
Author

问题主要是依赖定义不是自己写的, 而是某个依赖的依赖的依赖等等, 这个不好直接到上游去修改

@dead-horse
Copy link
Member

@ibigbug 会解决这个问题,合并到 #52

@dead-horse dead-horse reopened this Mar 16, 2016
@ibigbug
Copy link
Contributor

ibigbug commented Mar 16, 2016

嗯,在处理了。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants