Update .gitignore

[LoipesMas]

.gitignore was matching src/huak/env folder, so I re-included it.
Alternatively we could make venv dir matching more specific (e.g. only match them in root directory and/or huak-py). Should be fine either way.
Or we could remove matching env/ altogether, because pretty much no one uses that AFAIK ;)
Let me know what would you prefer!

[cnpryer]

Woah how didn't I notice this?

[cnpryer]

Curious how it hasn't been an issue.

[cnpryer]

This is a dumb nit, but couldn't we just do

/env/

[LoipesMas]

Curious how it hasn't been an issue.

I think it was added quite recently and git seems fine with changing ignored files, but won't register new ones.

[cnpryer]

My only problem with this really is that if the project structure ever changes we'd have to update that line, right?

[LoipesMas]

This is a dumb nit, but couldn't we just do

/env/

That's what I meant by making it more specific. This wouldn't work if someone had env/ in huak-py directory, but it can be handled on individual basis.

My only problem with this really is that if the project structure ever changes we'd have to update that line, right?

Yep

[cnpryer]

Well I think we can add a .gitignore to huak-py if that's the case (I think) There's already a gitignore in there. I'm just hesitant to hardcode things. If there's a future refactor big enough to impact project structure we'd have to remember to update that line.

[cnpryer]

I'll merge it, but I'm not sure this is a future-proof change to the gitignore. I think telling it to ignore specifically root level env folders would be.

[LoipesMas]

I totally forgot that you can have .gitignore in subdirectories. Since it's also handled there, I'll change it to match root dir only

[LoipesMas]

Should I change it for all environment names (venv, .venv, etc.) or just env? And do the same in huak-py/.gitignore?

[cnpryer]

Hmm. Don't do all. We sometimes have .venv (or venv) in resources for mock projects at the moment. Just env please!

[cnpryer]

I'm wrong! we have a gitignore there. if you want to do all (but .venv) that'd be great!

[cnpryer]

This is actually good. It's making me think about this more than I thought I'd need to. I don't think .venv needs to be, but maybe I'm missing something with that too.

[LoipesMas]

I think we can safely match only those env dirs that are in root directory and handle other ones in separate .gitignores (as we already do)

[cnpryer]

Thanks!