Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for Python binary resolution #352

Closed
cnpryer opened this issue Nov 21, 2022 · 3 comments
Closed

Improvements for Python binary resolution #352

cnpryer opened this issue Nov 21, 2022 · 3 comments
Milestone

Comments

@cnpryer
Copy link
Owner

cnpryer commented Nov 21, 2022

Following up on #335.

  • Use the implementation for Venv.create() to search the system for a Python binary to use to generate a venv with.
  • Optional Refactor the implementation for less redundant walking.
  • Optional Refactor the implementation for generic recursive path searching.
  • Optional Add recursion limit for walking dirs.
@messense
Copy link

Have you seen https://github.com/brettcannon/python-launcher? In maturin we also need to resolve Python binary location, it would be great if we can make python-launcher support Windows then reuse its code.

docs: https://docs.rs/python-launcher/1.0.0/python_launcher/

@cnpryer
Copy link
Owner Author

cnpryer commented Nov 21, 2022

Definitely willing to check it out. Thanks for sharing!

@cnpryer cnpryer added this to the General-use release milestone Oct 26, 2023
@cnpryer
Copy link
Owner Author

cnpryer commented Nov 16, 2023

Toolchains somewhat resolve this

@cnpryer cnpryer closed this as completed Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants