Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

huak fmt --check will exit early if imports aren't sorted #510

Open
cnpryer opened this issue Mar 27, 2023 · 0 comments
Open

huak fmt --check will exit early if imports aren't sorted #510

cnpryer opened this issue Mar 27, 2023 · 0 comments
Milestone

Comments

@cnpryer
Copy link
Owner

cnpryer commented Mar 27, 2023

In order to check both imports and the rest of Python source code, huak uses ruff and black. In the future, ideally, only ruff will be necessary. Otherwise better process management could resolve this.

If --check is passed to huak fmt, huak will first run the ruff check on the imports. huak will emit a warning about this issue prior to running the check. At the moment if non-zero exit codes are returned from these commands, huak exits immediately with the code. This means the black check won't run if ruff exits with non-zero.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant