Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💥 should smarter_id change its format? #73

Open
bunop opened this issue Oct 4, 2022 · 0 comments
Open

💥 should smarter_id change its format? #73

bunop opened this issue Oct 4, 2022 · 0 comments
Labels
bug Something isn't working question Further information is requested
Projects

Comments

@bunop
Copy link
Member

bunop commented Oct 4, 2022

Is your feature request related to a problem? Please describe.
The smarter_id attribute is not a good primary key since it incorporates additional information in its name like country and breed_code. This means that modifing a country or a breed_code for a sample causes inconsistencies between this primary id and fields, having a stable id which contains wrong informations. On the other way, fixing smarter_id relying on new data means that these ids will change with database version.

Describe the solution you'd like
smarter_ids shold be anonymizes, maybe tracking the project name with the number (like SMARTER-OA-000002310, species need to be kept to avoid name collisions between goat and sheep

Describe alternatives you've considered
An alternative could be fix stuff after data import, using a mongoengine query to correct wrong values keeping smarter_id stable. However this means not to trust information in ids anymore.

Additional context
The Galway sheeps breed was tracked as Germany instead of Ireland since country was derived from a wrong set of coordinates. Code and country need to be fixed

@bunop bunop added bug Something isn't working question Further information is requested labels Oct 4, 2022
@bunop bunop added this to the SMARTER database v1.0.0 milestone Oct 4, 2022
@bunop bunop added this to To do in SMARTER via automation Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
Status: To do
SMARTER
To do
Development

No branches or pull requests

1 participant