New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug for Normal Update. #156

Open

FishHe opened this issue Dec 9, 2020 · 0 comments

Assignees

Labels

bug

FishHe commented Dec 9, 2020

https://github.com/cnr-isti-vclab/vcglib/blob/master/vcg/complex/algorithms/update/normal.h

at line 350~358:


    if(remove_scaling){
        scale = pow(mat33.Determinant(),(ScalarType)(1.0/3.0));
        Point3<ScalarType> scaleV(scale,scale,scale);
        Matrix33<ScalarType> S;
        S.SetDiagonal(scaleV.V());
        mat33*=S;
    }

The scale factor should not be multiplied. The right operation should be mat33/=S;

The text was updated successfully, but these errors were encountered:

malomo added the bug label

malomo self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment