Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration test: is there a readiness entry in the Helm chart? #57

Closed
3 of 13 tasks
lixuna opened this issue Feb 25, 2020 · 3 comments
Closed
3 of 13 tasks

Configuration test: is there a readiness entry in the Helm chart? #57

lixuna opened this issue Feb 25, 2020 · 3 comments
Assignees
Labels
5 pts configuration + lifecycle configuration and lifecycle cloud native principles workload

Comments

@lixuna
Copy link
Collaborator

lixuna commented Feb 25, 2020

Acceptance Criteria

Configuration test: is there a readiness entry in the Helm chart?

EPIC: CNF Conformance Test Suite

Release: v0.0.1

Test Category: Configuration and Lifecycle

Type of test (static or runtime) =


Environment set up tasks:

Upstream tool set up tasks: (conformance suite + upstream tools)

  • N/A

CNF setup Tasks

Sample CNF tasks:

Documentation tasks:

QA tasks

Dev Review:

  • walk through A/C
  • do you get the expected result?
  • if yes, move to Needs Peer Review column
  • if no, document what additional tasks will be needed

Peer review:

  • walk through A/C
  • do you get the expected result?
  • if yes, move to Reviewer Approved column
  • if no, document what did not go as expected, including error messages and screenshots (if possible)
@lixuna lixuna added the configuration + lifecycle configuration and lifecycle cloud native principles label Feb 25, 2020
@lixuna lixuna added this to To do in CNF Test Suite via automation Feb 25, 2020
@lixuna lixuna moved this from To do to In Planning in CNF Test Suite Feb 25, 2020
@wvwatson wvwatson moved this from In Planning to In progress in CNF Test Suite Feb 27, 2020
@wvwatson wvwatson moved this from In progress to In Planning in CNF Test Suite Feb 27, 2020
@taylor taylor moved this from In Planning to Ready for Dev in CNF Test Suite Mar 2, 2020
@taylor taylor moved this from Ready for Dev to In progress in CNF Test Suite Mar 2, 2020
@williscool williscool moved this from In progress to Needs Peer Review in CNF Test Suite Mar 2, 2020
@taylor taylor moved this from Needs Peer Review to In progress in CNF Test Suite Mar 2, 2020
@taylor
Copy link
Collaborator

taylor commented Mar 2, 2020

@wavell @denverwilliams @williscool please add A/C before moving to Needs Peer Review

@taylor taylor moved this from In progress to In Planning in CNF Test Suite Mar 2, 2020
@lixuna
Copy link
Collaborator Author

lixuna commented Mar 3, 2020

Acceptance Criteria:

Common steps

  • Find or create a K8s cluster to use
    • Steps for creating will be in another ticket
    • Talk with team for access to an existing cluster
  • Set the KUBECONFIG environment variable for accessing the target K8s cluster
  • As a developer, Pull down latest version of CNF conformance test code from develop branch
  • As a peer reviewer, Pull down latest version of CNF conformance test code from master branch
  • Run shards install
  • Run crystal spec
  • I expect to see PASSED for the tests

When using the test crystal src/cnf-conformance.cr readiness command the sample "good" CNF should PASS test successfully:

  • Run crystal src/cnf-conformance.cr setup
  • Run crystal src/cnf-conformance.cr sample_coredns_setup
  • Run crystal src/cnf-conformance.cr readiness
  • I expect to see the output and results from the test
  • I expect to see PASSED for the test

When using the test crystal spec --tag 'readiness' command the sample "good" CNF should PASS and the sample "bad" CNF should FAIL test:

  • Run crystal spec --tag 'readiness'
  • I expect to see the output and results from the test
  • I expect to see "PASSED: Helm readiness probe found"
  • I expect to see "FAILURE: No readinessProbe found"

I would expect the CNF to pass when I run the entire test category suite (configuration_lifecycle)

  • Run crystal src/cnf-conformance.cr configuration_lifecycle
  • I expect to see the output and results from all tests in the test category
  • I expect to see PASSED for the test category

I would expect the CNF to pass when I run the entire test suite (all)

  • Follow common steps above
  • Run crystal src/cnf-conformance.cr all
  • I expect to see the output from the test
  • I expect to see PASSED for the test

Steps after A/C fails

If all A/C fails for peer reviewer

  • Add a comment to the PR summarizing the problem tagging the developer
  • Attach any console output or logs that can help the developer fix the issue

Steps after A/C Passes

If all A/C passes for developer

  • open a Pull Request to master branch and mark as "developer approved"
  • Tag team members for peer review

If all A/C passes for peer reviewer

  • Mark the PR as approved and merge the PR into master

@lixuna
Copy link
Collaborator Author

lixuna commented Mar 3, 2020

Level of effort in pts: 0, 1, 2, 3, 5, 8, 13, 21 = 5 pts

@wavell 5 pts
@denverwilliams 5 pts
@taylor 3 pts
@lixuna 3 pts

@lixuna lixuna added the 5 pts label Mar 3, 2020
@lixuna lixuna moved this from In Planning to Ready for Dev in CNF Test Suite Mar 3, 2020
@taylor taylor moved this from Ready for Dev to In progress in CNF Test Suite Mar 13, 2020
@taylor taylor moved this from In progress to Ready for Dev in CNF Test Suite Mar 13, 2020
@denverwilliams denverwilliams moved this from Ready for Dev to In progress in CNF Test Suite Mar 16, 2020
@wvwatson wvwatson moved this from In progress to Needs Peer Review in CNF Test Suite Mar 17, 2020
@lixuna lixuna added this to the CNF Conformance Workload Tests milestone Apr 15, 2020
@taylor taylor moved this from Needs Peer Review to Reviewer approved in CNF Test Suite Apr 23, 2020
@lixuna lixuna moved this from Reviewer approved to Done in CNF Test Suite Apr 23, 2020
@lixuna lixuna closed this as completed Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 pts configuration + lifecycle configuration and lifecycle cloud native principles workload
Projects
Development

No branches or pull requests

4 participants