Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RA2 Ch2] Wording to deal with requirements that are optional at deployment time. #1130

Merged
merged 3 commits into from Mar 5, 2020

Conversation

tomkivlin
Copy link
Collaborator

Resolves #1048

@tomkivlin tomkivlin added this to the M3 (Freeze Contributions) milestone Feb 20, 2020
@tomkivlin tomkivlin added this to In Progress in old-RA2 via automation Feb 20, 2020
@tomkivlin
Copy link
Collaborator Author

@fkautz are you happy with this wording? If so could you approve please? If so, I think it'll mean we can close #1014.

@hdamker
Copy link
Collaborator

hdamker commented Feb 26, 2020

Just the question if we shouldn't be more explicit about the optional deployment. Is it a must requirement that the operator can choose within a deployment to deploy or not deploy persistent storage. Or may the reference/vendor implementation allow this option?

I'm in favor of a second, explicit requirement with either may or must for deployment choice. The implicit meaning of "optional for deployment" leaves too many interpretations.

@tomkivlin
Copy link
Collaborator Author

Just the question if we shouldn't be more explicit about the optional deployment. Is it a must requirement that the operator can choose within a deployment to deploy or not deploy persistent storage. Or may the reference/vendor implementation allow this option?

So definitely not "may the reference/vendor implementation allow this option". RI/VI must include it so they can be tested.

The RI/VI are a kind of solution blueprint, not individual solution deployments. It is these solution deployments where an operator might choose to use the capability or not, depending on their requirements for that specific deployment.

I'm in favor of a second, explicit requirement with either may or must for deployment choice. The implicit meaning of "optional for deployment" leaves too many interpretations.

What I'm trying to avoid is having requirements in the RA, which aren't about the RA. More than happy to consider re-wording what we've got here, but want to keep the requirements we list in this doc to be about what this doc is delivering (i.e. the architecture spec).

@rabiabdel
Copy link
Collaborator

@hdamker please review to get this approved/merged. this will merged within 48 hours if no concern received.

doc/ref_arch/kubernetes/chapters/chapter02.md Outdated Show resolved Hide resolved
doc/ref_arch/kubernetes/chapters/chapter02.md Outdated Show resolved Hide resolved
@rabiabdel
Copy link
Collaborator

Will approve this and merge it tomorrow if no further feedback received by EOT

@hdamker
Copy link
Collaborator

hdamker commented Mar 3, 2020

Will approve this and merge it tomorrow if no further feedback received by EOT

@rabiabdel my proposed changes are positively discussed but not yet done within. @tomkivlin: will you do them? It's your PR.

@tomkivlin
Copy link
Collaborator Author

Will approve this and merge it tomorrow if no further feedback received by EOT

@rabiabdel my proposed changes are positively discussed but not yet done within. @tomkivlin: will you do them? It's your PR.

Yes, it's on my list to make the change tomorrow morning.

@rabiabdel rabiabdel merged commit 9fc7832 into master Mar 5, 2020
old-RA2 automation moved this from In Progress to Done Mar 5, 2020
@rabiabdel rabiabdel deleted the tomkivlin-ra2-fixes1048 branch March 5, 2020 11:21
@rabi-abdel rabi-abdel added the Archive Archive Item label May 15, 2020
@rabi-abdel rabi-abdel removed this from the M3 (Freeze Contributions) milestone May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Archive Archive Item
Projects
No open projects
old-RA2
  
Done
Development

Successfully merging this pull request may close these issues.

[RA1 RA2] Express conditional requirements for implementations based on SW/HW profiles
10 participants