[RA2 Ch4]: Removal of VMware NCP

[CsatariGergely]

Fixes #1378

[tomkivlin]

I don't think the whole merge needs reversing. I am ok with NCP being listed, but we do need to highlight that it is not open source, perhaps a reference to the CNTT principles in the comparison table?

[ramkri123]

Agree with Tom's observation.

There is no mandate for the CNI plugin to be open source as long as the plugin adheres to the CNI specification -- https://github.com/containernetworking/cni. Other examples of non-open-source plugins are ACI, Nuage etc. -- they are described in https://kubernetes.io/docs/concepts/cluster-administration/addons/.

[tomkivlin]

Agree with Tom's observation.

There is no mandate for the CNI plugin to be open source as long as the plugin adheres to the CNI specification -- https://github.com/containernetworking/cni. Other examples of non-open-source plugins are ACI, Nuage etc. -- they are described in https://kubernetes.io/docs/concepts/cluster-administration/addons/.

I think the point is that there is a CNTT principle that we only used open source technologies. However, it is a principle, so I think worth adding but highlighting.

[ramkri123]

Hi Tom,

Would the following changes help clarify.

1. In the NCP text
   Note that NCP is not a open source CNI plugin, but adheres to the CNI specification -- https://github.com/containernetworking/cni. Other examples of non-open-source CNI plugins are ACI, Nuage etc. -- they are described in https://kubernetes.io/docs/concepts/cluster-administration/addons/.

2. In the NCP column in the table
   Not open source

Thanks,
Ramki

[CsatariGergely]

I don't think the whole merge needs reversing. I am ok with NCP being listed, but we do need to highlight that it is not open source, perhaps a reference to the CNTT principles in the comparison table?

1. [RA2 Ch4] updates to include NSX Container plugin(NCP) #1370 was merged before reaching a consensus.
2. I think having a principle to use only open source technologies would mean that we use only open source technologies.
3. If I understand correctly this CNI assumes that the Kubernetes cluster runs on top of VM-s in a VMware vCloud environment.
4. I'm still not convinced that this is a metaplugin

[tomkivlin]

Meeting 2nd April:

• Tom agreed with points 1/2 above
• Principle compliance should be made, unless there isn't an option that complies with all principles
• Do we need a discussion about "open source" - what it means - is an open source software owned by one company with contributions only from that company any better than proprietary? Yes - but not in this PR :) @tomkivlin to raise an issue.

[xmulligan]

another is one word, otherwise lgtm

[CsatariGergely]

another is one word, otherwise lgtm

Done