Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RM Ch03] Update chapter03.md #2404

Merged
merged 6 commits into from May 23, 2021
Merged

[RM Ch03] Update chapter03.md #2404

merged 6 commits into from May 23, 2021

Conversation

arkadykanevsky
Copy link
Collaborator

Adding reference for SyncE and NTP, and more clarifications.

Update chapter03.md
3883ae6 
Adding reference for SyncE and NTP, and more clarifications.
Arkady Kanevsky and others added 2 commits May 6, 2021 13:24
@pgoyal01
Update doc/ref_model/chapters/chapter03.md
81984f2 
Co-authored-by: Pankaj Goyal <52107136+pgoyal01@users.noreply.github.com>
@pgoyal01
Update doc/ref_model/chapters/chapter03.md
d02a608 
Co-authored-by: Pankaj Goyal <52107136+pgoyal01@users.noreply.github.com>
@arkadykanevsky
Copy link
Collaborator Author

Thanks Pankaj. Your suggestions accepted.

pgoyal01
pgoyal01 reviewed May 6, 2021
View reviewed changes
doc/ref_model/chapters/chapter03.md Outdated
@@ -379,9 +379,9 @@ The SFC management components together with the control components are responsib

Precise Synchronization require specialized card that can be on server or network device motherboard or be part of NIC or both.

OpenStack and Kubernetes clusters use Network Time Protocol [NTP] (RFC 5905: Network Time Protocol Version 4: Protocol and Algorithms Specification, RFC 5906: Network Time Protocol Version 4: Autokey Specification, RFC 5907: Definitions of Managed Objects for Network Time Protocol Version 4 (NTPv4), RFC 5908: Network Time Protocol (NTP) Server Option for DHCPv6) as the default time synchronization for the cluster. That level of synchronization is not sufficient for many network functions. Just like real-time operating system requirement instead of base OS so is precision timing for clock synchronization. Precision Time Protocol version 2 [PTP] (IEEE 1588-2019) is commonly used for Time-Sensitive Networking. This allow synchronization in microsecond range rather than millisecond range that NTP provides.
OpenStack and Kubernetes clusters use Network Time Protocol (NTP) ([Protocol and Algorithms Specification](RFC 5905: Network Time Protocol Version 4: Protocol and Algorithms Specification), [Autokey Specification](RFC 5906: Network Time Protocol Version 4: Autokey Specification), [Managed Objects](RFC 5907: Definitions of Managed Objects for Network Time Protocol Version 4 (NTPv4)), and [Server Option for DHCPv6](RFC 5908: Network Time Protocol (NTP) Server Option for DHCPv6)) as the default time synchronization for the cluster. That level of synchronization is not sufficient for many network functions. Just like real-time operating systems instead of base OS, so is precision timing for clock synchronization. Precision Time Protocol version 2 [PTP](IEEE 1588-2019) is commonly used for Time-Sensitive Networking. This allow synchronization in microsecond range rather than millisecond range that NTP provides.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Option 2:

Suggested change
OpenStack and Kubernetes clusters use Network Time Protocol (NTP) ([Protocol and Algorithms Specification](RFC 5905: Network Time Protocol Version 4: Protocol and Algorithms Specification), [Autokey Specification](RFC 5906: Network Time Protocol Version 4: Autokey Specification), [Managed Objects](RFC 5907: Definitions of Managed Objects for Network Time Protocol Version 4 (NTPv4)), and [Server Option for DHCPv6](RFC 5908: Network Time Protocol (NTP) Server Option for DHCPv6)) as the default time synchronization for the cluster. That level of synchronization is not sufficient for many network functions. Just like real-time operating systems instead of base OS, so is precision timing for clock synchronization. Precision Time Protocol version 2 [PTP](IEEE 1588-2019) is commonly used for Time-Sensitive Networking. This allow synchronization in microsecond range rather than millisecond range that NTP provides.
OpenStack and Kubernetes clusters use Network Time Protocol (NTP) ([Protocol and Algorithms Specification](https://tools.ietf.org/html/rfc5905), [Autokey Specification](https://tools.ietf.org/html/rfc5906), [Managed Objects](https://tools.ietf.org/html/rfc5907), and [Server Option for DHCPv6](https://tools.ietf.org/html/rfc5908)) as the default time synchronization for the cluster. That level of synchronization is not sufficient for many network functions. Just like real-time operating systems instead of base OS, so is precision timing for clock synchronization. Precision Time Protocol version 2 [PTP](https://standards.ieee.org/standard/1588-2019.html) is commonly used for Time-Sensitive Networking. This allow synchronization in microsecond range rather than millisecond range that NTP provides.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arkadykanevsky If you accept this suggestion then the references to RFC's will also be hyperlinks to the documents. Thanks

Arkady Kanevsky and others added 2 commits May 6, 2021 15:05
@pgoyal01
Update doc/ref_model/chapters/chapter03.md
a962662 
Co-authored-by: Pankaj Goyal <52107136+pgoyal01@users.noreply.github.com>
@pgoyal01
Update doc/ref_model/chapters/chapter03.md
1fca99a 
Co-authored-by: Pankaj Goyal <52107136+pgoyal01@users.noreply.github.com>
@arkadykanevsky
Copy link
Collaborator Author

Thanks Pankaj.
I committed hyperlinks. Looks cleaner.
Again Thanks.

@pgoyal01 pgoyal01 changed the title Update chapter03.md [RM Ch03] Update chapter03.md May 6, 2021
@wmk-admin wmk-admin requested a review from a team May 11, 2021 06:08
@walterkozlowski walterkozlowski requested review from a team and TFredberg May 12, 2021 14:15
TFredberg
TFredberg approved these changes May 12, 2021
View reviewed changes
Copy link
Collaborator

@TFredberg TFredberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the content is OK, but the very long parentheses after NTP, make it very hard to read. I would suggest reformatting it a bit to make the content of the parentheses as a separate sentence and a bulleted list.
I also think a minor change of "... not sufficient for many Network Functions .." exchanging "many" to "some" would be better, since it is by far not a majority of workloads that needs it.

@arkadykanevsky
Copy link
Collaborator Author

Incorporated Pankaj comments and some of Tomas ones.

@arkadykanevsky
Copy link
Collaborator Author

Walter, needs your final approval for a merge.

@bfcohen100
Copy link
Contributor

Approved.

bfcohen100
bfcohen100 approved these changes May 19, 2021
View reviewed changes
Copy link
Contributor

@bfcohen100 bfcohen100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

bfcohen100
bfcohen100 approved these changes May 19, 2021
View reviewed changes
Copy link
Contributor

@bfcohen100 bfcohen100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

bfcohen
bfcohen approved these changes May 19, 2021
View reviewed changes
Copy link
Collaborator

@bfcohen bfcohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes

@pgoyal01 pgoyal01 added this to In Progress in RM May 20, 2021
@walterkozlowski walterkozlowski merged commit 10dcb45 into master May 23, 2021
RM automation moved this from In Progress to Done May 23, 2021
@walterkozlowski walterkozlowski deleted the arkadykanevsky-patch-1 branch May 23, 2021 05:42
@arkadykanevsky
Copy link
Collaborator Author

Walter, Can you merge it, please. It has 3 approvals.

sureshkrishnan
sureshkrishnan reviewed May 26, 2021
View reviewed changes
doc/ref_model/chapters/chapter03.md Outdated
@@ -379,9 +379,16 @@ The SFC management components together with the control components are responsib

Precise Synchronization require specialized card that can be on server or network device motherboard or be part of NIC or both.

OpenStack and Kubernetes clusters use NTP as the default time synchronization for the cluster. That level of synchronization is not sufficient for many network functions. Just like real-time operating system requirement instead of base OS so is precision timing for clock synchronization. Precision Time Protocol version 2 [PTP] (IEEE 1588-2019) is commonly used for Time-Sensitive Networking. This allow synchronization in microsecond range rather than millisecond range that NTP provides.
OpenStack and Kubernetes clusters use Network Time Protocol [NTP] (RFC 5905: Network Time Protocol Version 4: Protocol and Algorithms Specification, RFC 5906: Network Time Protocol Version 4: Autokey Specification, RFC 5907: Definitions of Managed Objects for Network Time Protocol Version 4 (NTPv4), RFC 5908: Network Time Protocol (NTP) Server Option for DHCPv6) as the default time synchronization for the cluster. That level of synchronization is not sufficient for many network functions. Just like real-time operating system requirement instead of base OS so is precision timing for clock synchronization. Precision Time Protocol version 2 [PTP] (IEEE 1588-2019) is commonly used for Time-Sensitive Networking. This allow synchronization in microsecond range rather than millisecond range that NTP provides.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This text does not expand on why NTP is not sufficient ("That level"). Suggest changing

"That level of synchronization is not sufficient for many network functions."

to

"The level of synchronization offered by NTP may not be sufficient for many network functions."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sureshkrishnan sureshkrishnan sureshkrishnan left review comments

@pgoyal01 pgoyal01 pgoyal01 left review comments

@bfcohen100 bfcohen100 bfcohen100 approved these changes

@petorre petorre petorre approved these changes

@TFredberg TFredberg TFredberg approved these changes

@bfcohen bfcohen bfcohen approved these changes

@walterkozlowski walterkozlowski walterkozlowski approved these changes

@scottsteinbrueck scottsteinbrueck Awaiting requested review from scottsteinbrueck

@CsatariGergely CsatariGergely Awaiting requested review from CsatariGergely

Assignees
No one assigned
Labels
None yet
Projects
RM
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@arkadykanevsky @bfcohen100 @sureshkrishnan @petorre @TFredberg @pgoyal01 @bfcohen @walterkozlowski