[RM Ch04] Rewrite of 4.2 aligned with RM 2.4 #2450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
major changes and renumbering to align with concepts introduced in RM 2.4; also incorporates some of the content from PR #2320 (it has been reworded for flow etc.) under Section 4.2
pgoyal01
requested review from
ildikov,
petorre,
karinesevilla,
walterkozlowski,
ulikleber and
a team
This was referenced May 24, 2021
Closed
|
@walterkozlowski recommended using this PR for other minor changes including Title of Section 2.4 and adding a sentence with a reference to Section 4.2. |
@walterkozlowski recommended using this PR for other minor changes including Title of Section 2.4 and adding a sentence with a reference to Section 4.2. Done with this commit.
petorre
reviewed
May 25, 2021
|
In RM-ch04-node-profiles.*, word "Indeterminate" does not sound right for AAA. I don't have a better one though. @petorre Changed to "non-predictable" -- does that work? |
pgoyal01
commented
May 25, 2021
pgoyal01
commented
May 25, 2021
Changed "Indeterminate" to "Non-predictable" as per @petorre
Adding Network Intensive Profile Extension using SR-IOV
petorre
reviewed
May 27, 2021
Co-authored-by: Petar Torre <petar.torre@intel.com>
pgoyal01
commented
May 31, 2021
Typo -- added space
pgoyal01
commented
Jun 1, 2021
pgoyal01
commented
Jun 1, 2021
ulikleber
approved these changes
Jun 2, 2021
|
|
||
| <p align="center"><img src="../figures/ch04_vnf_design.png" alt="workload_design" title="Workload Design" width="65%"/></p> | ||
| <p align="center"><b>Figure 4-2:</b> Workloads built against Cloud Infrastructure Profiles and compute Flavours.</p> | ||
| <p align="center"><img src="../figures/RM-ch04-node-profiles.png" alt="node_workload_profiles" title="Node and Workload Profiles" width="65%"/></p> |
There was a problem hiding this comment.
The figure shows a profile "N" for High Performance (later "H").
There was a problem hiding this comment.
@ulikleber I don't see the "N" in this figure -- maybe we can have a session to walk through.
petorre
approved these changes
Jun 2, 2021
Co-authored-by: Ulrich Kleber <53302540+ulikleber@users.noreply.github.com>
Co-authored-by: Ulrich Kleber <53302540+ulikleber@users.noreply.github.com>
Co-authored-by: Ulrich Kleber <53302540+ulikleber@users.noreply.github.com>
adopt suggestion of @karinesevilla on CPU allocation ratio
|
@petorre @ulikleber Thanks for your valuable suggestions and review. For some reason your reviews do not showup in the Reviewers with the green tick mark. Would it be possible for you to re-approve? Thanks |
karinesevilla
approved these changes
Jun 3, 2021
walterkozlowski
approved these changes
Jun 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2366
major changes and renumbering to align with concepts introduced in RM 2.4; also incorporates some of the content from PR #2320 (it has been reworded for flow etc.) under Section 4.2
Figures will be updated with further commits