-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gov, common]: Convert to rst #2737
[gov, common]: Convert to rst #2737
Conversation
CsatariGergely
commented
Nov 29, 2021
- Removal of raw HTML elements
- Removal of ToC
- Removal of bogometers
- Adding new line before and after lists
- Harmonizing buleted lists to use *
- Adding new line before and after headings
* Removal of raw HTML elements * Removal of ToC * Removal of bogometers * Adding new line before and after lists * Harmonizing buleted lists to use * * Adding new line before and after headings Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Implementing the markdown corrections to the release notes Adding the image captions to the corrected markdowns in GOV and Common Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Figure numbers do not render |
Fixed in 49c7e0a |
I moved this to draft as I would like to convert to rst already in this pr. |
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
|
||
**Definitions** | ||
|
||
A project (aka WS) is: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and "Releases" are not section headings and so wouldn't have implicit references - for milestones an explicit reference has been created (line 61) :
Projects <#project>
__ and Releases <#release>
__
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any links pointing to here?
I'm a bit lost now with the implicit header anchoring. In my view they work only until we use links to .md files and use the relative link corrector extension. Later we can use sphinx.ext.autosectionlabel or we can just add labels manually. Any opinions or preferences? @pgoyal01 , @karinesevilla , @gkunz , @collivier ?
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@pgoyal01 can you please close the conversations if you accept my comments or add a comment if not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the links have been addressed.
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
…TT into common-rst-markdown-corrections Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@walterkozlowski can you please merge? |