Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RM] Fix 2 anonymous hyperlink mismatches #2832

Merged
merged 3 commits into from Mar 19, 2022

Conversation

collivier
Copy link
Collaborator

It basically forbids rendering any document.
See "backrefs" attribute for IDs.

Signed-off-by: Cédric Ollivier cedric.ollivier@orange.com

@collivier collivier self-assigned this Mar 1, 2022
@collivier collivier added the bug Something isn't working label Mar 1, 2022
@collivier collivier added this to In Progress in RM via automation Mar 1, 2022
@collivier collivier added this to the Moselle - M2 - Scope Freeze milestone Mar 1, 2022
@pgoyal01 pgoyal01 requested a review from a team March 1, 2022 17:23
@pgoyal01
Copy link
Collaborator

pgoyal01 commented Mar 1, 2022

@collivier I realise that my ask is not related to the PR but there is an issue at line 591: "3.5.6 Time Sensitive Networking" -- the section number needs to be deleted

@pgoyal01
Copy link
Collaborator

pgoyal01 commented Mar 1, 2022

The external references like in line 124: "Storage Extensions <./chapter04.md#4.2.6>__ section" should be changed to: "Storage Extensions <./chapter04.md#storage-extensions>__ section"

@collivier
Copy link
Collaborator Author

@pgoyal01 Thank you for the review. This ref is being modified in a bigger change removing all obsolete md refs (I added a second commit to share the work in progress). The first proposal you commented was a crucial quick fix for an issue which breaks everything (and which is very difficult to detect). But I'm finishing the second commit before the first one is reviewed.

Copy link
Collaborator Author

@collivier collivier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It must be double checked both by RM team! It's an early share to highlight all the issues.

@collivier collivier force-pushed the fix_rm-rst branch 4 times, most recently from 149061f to 889c592 Compare March 7, 2022 08:50
Copy link
Collaborator

@karinesevilla karinesevilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@collivier For chapter 7, all external links are good.
There as still 3 internal links to fix:
Sections: Root of trust for measurements(RTM), 7.6.1 and Zero trust architecture, 7.6.1 and 7.6.5

@pgoyal01 pgoyal01 requested a review from a team March 9, 2022 20:25
doc/ref_model/chapters/chapter05.rst Outdated Show resolved Hide resolved
doc/ref_model/chapters/chapter05.rst Outdated Show resolved Hide resolved
doc/ref_model/chapters/chapter05.rst Outdated Show resolved Hide resolved
collivier and others added 3 commits March 18, 2022 11:23
It basically forbids rendering any document.
See "backrefs" attribute for IDs.

Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
They were all detected by linkcheck.

It doesn't leverage any title 3 link as they would ask Anuket to
remove all duplicated at this level.
(see Synopsis or Introduction as blocking points)

Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
Co-Authored-By: Georg Kunz <georg.kunz@ericsson.com>
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
@walterkozlowski walterkozlowski merged commit 7048723 into anuket-project:master Mar 19, 2022
RM automation moved this from In Progress to Done Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
RM
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants