Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ra2] convert to list-tables #3042

Merged
merged 11 commits into from Jun 9, 2022
Merged

[ra2] convert to list-tables #3042

merged 11 commits into from Jun 9, 2022

Conversation

rgstori
Copy link
Collaborator

@rgstori rgstori commented Jun 8, 2022

No description provided.

Copy link
Collaborator

@pgoyal01 pgoyal01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one suggested change

@pgoyal01 pgoyal01 requested a review from a team June 8, 2022 14:49
@pgoyal01 pgoyal01 added this to In Progress in old-RA2 via automation Jun 8, 2022
@pgoyal01 pgoyal01 added this to the Moselle - M5 - Release Readiness milestone Jun 8, 2022
@rgstori rgstori marked this pull request as ready for review June 8, 2022 16:49
@rgstori
Copy link
Collaborator Author

rgstori commented Jun 8, 2022

@cntt-n/ref-a2 this is ready for review now

-
* - `7.9.1`
- sec.gen.004
- The Operating Systems of all the servers part of Cloud Infrastructure **must** be hardened by removing or disabling unnecessary services, applications and network protocols, configuring operating system user authentication, configuring resource controls, installing and configuring additional security controls where needed, and testing the security of the Operating System. (NIST SP 800-123)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to linewrap to al least 120 chars even in this case?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Collaborator

@pgoyal01 pgoyal01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

splitting long lines

doc/ref_arch/kubernetes/chapters/chapter02.rst Outdated Show resolved Hide resolved
doc/ref_arch/kubernetes/chapters/chapter02.rst Outdated Show resolved Hide resolved
-
* - `7.9.1`
- sec.gen.004
- The Operating Systems of all the servers part of Cloud Infrastructure **must** be hardened by removing or disabling unnecessary services, applications and network protocols, configuring operating system user authentication, configuring resource controls, installing and configuring additional security controls where needed, and testing the security of the Operating System. (NIST SP 800-123)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

doc/ref_arch/kubernetes/chapters/chapter02.rst Outdated Show resolved Hide resolved
doc/ref_arch/kubernetes/chapters/chapter02.rst Outdated Show resolved Hide resolved
doc/ref_arch/kubernetes/chapters/chapter02.rst Outdated Show resolved Hide resolved
doc/ref_arch/kubernetes/chapters/chapter02.rst Outdated Show resolved Hide resolved
doc/ref_arch/kubernetes/chapters/chapter02.rst Outdated Show resolved Hide resolved
doc/ref_arch/kubernetes/chapters/chapter02.rst Outdated Show resolved Hide resolved
doc/ref_arch/kubernetes/chapters/chapter02.rst Outdated Show resolved Hide resolved
rgstori and others added 2 commits June 9, 2022 12:36
Co-authored-by: Pankaj Goyal <52107136+pgoyal01@users.noreply.github.com>
@rgstori rgstori requested review from CsatariGergely and a team June 9, 2022 11:41
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
Copy link
Collaborator

@CsatariGergely CsatariGergely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually I think we need to linewrap all lines to 120 chars. I'm okay to address this in some later pr.

doc/ref_arch/kubernetes/chapters/chapter04.rst Outdated Show resolved Hide resolved
doc/ref_arch/kubernetes/chapters/chapter04.rst Outdated Show resolved Hide resolved
Co-authored-by: Gergely Csatari <gergely.csatari@nokia.com>
@rgstori rgstori requested review from CsatariGergely and a team June 9, 2022 14:27
@rgstori rgstori merged commit 0622f5e into master Jun 9, 2022
old-RA2 automation moved this from In Progress to Done Jun 9, 2022
@rgstori rgstori deleted the rgs-ra2-list-tables branch June 9, 2022 15:11
collivier pushed a commit that referenced this pull request Jun 10, 2022
* [ra2 ch3] convert to list-tables

* [ra2 ch4] convert to list-tables

* [ra2 ch1] convert to list-tables

* [ra2 ch2] convert to list-tables

* [ra2 ch6] convert to list-tables

* [ra2 ch7] convert to list-tables

* split long line

* Apply suggestions from code review

Co-authored-by: Pankaj Goyal <52107136+pgoyal01@users.noreply.github.com>

* Fix a few ref issues

Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>

* Apply suggestions from code review

Co-authored-by: Gergely Csatari <gergely.csatari@nokia.com>

Co-authored-by: Pankaj Goyal <52107136+pgoyal01@users.noreply.github.com>
Co-authored-by: Cédric Ollivier <cedric.ollivier@orange.com>
Co-authored-by: Gergely Csatari <gergely.csatari@nokia.com>
(cherry picked from commit 0622f5e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
old-RA2
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants