Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RA1 Ch[02-08]] Typo, grammar and empty tables #3170

Merged
merged 1 commit into from Sep 13, 2022

Conversation

pgoyal01
Copy link
Collaborator

Comment off the empty Tenenat Recommendations table

@pgoyal01 pgoyal01 added the minor Pull request suggesting minor/editorial changes label Sep 11, 2022
@pgoyal01 pgoyal01 added this to the GSMA Editing milestone Sep 11, 2022
@pgoyal01 pgoyal01 added this to In Progress in RA1 via automation Sep 11, 2022
@pgoyal01 pgoyal01 changed the title [RA1 Ch02] Typo, grammar and empty tables -- WIP [RA1 Ch[02-08]] Typo, grammar and empty tables Sep 11, 2022
@pgoyal01 pgoyal01 requested a review from a team September 11, 2022 18:39
@pgoyal01
Copy link
Collaborator Author

@collivier @karinesevilla @ildikov please review and suggest corrections. Once PR is merged the GSMA document will need to be recreated.

Copy link
Collaborator

@karinesevilla karinesevilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pgoyal01 Thanks for the review and correction of the spelling and grammar issues. I will approve all of them.
Please consider the comments about empty table and numref

Copy link
Collaborator Author

@pgoyal01 pgoyal01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karine undoing changes on numref -- if you accept the suggestions

doc/ref_arch/openstack/chapters/chapter04.rst Outdated Show resolved Hide resolved
doc/ref_arch/openstack/chapters/chapter04.rst Show resolved Hide resolved
doc/ref_arch/openstack/chapters/chapter04.rst Outdated Show resolved Hide resolved
doc/ref_arch/openstack/chapters/chapter04.rst Outdated Show resolved Hide resolved
doc/ref_arch/openstack/chapters/chapter04.rst Outdated Show resolved Hide resolved
doc/ref_arch/openstack/chapters/chapter04.rst Show resolved Hide resolved
@collivier collivier force-pushed the pgoyal01-patch-RA1-corrections branch 3 times, most recently from 82eb1a4 to 90e2545 Compare September 12, 2022 16:17
Comment off the empty Tenenat Recommendations table
@collivier
Copy link
Collaborator

@pgoyal01 could you please double check I didn't fail when rebasing it?

@collivier collivier merged commit 7cb3e3b into master Sep 13, 2022
RA1 automation moved this from In Progress to Done Sep 13, 2022
collivier pushed a commit that referenced this pull request Sep 13, 2022
Comment off the empty Tenenat Recommendations table

(cherry picked from commit 7cb3e3b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Pull request suggesting minor/editorial changes
Projects
RA1
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants