Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RI Ch07] Update Ch07.md #888

Closed
wants to merge 1 commit into from
Closed

[RI Ch07] Update Ch07.md #888

wants to merge 1 commit into from

Conversation

lei-cloud
Copy link
Collaborator

I've added some contents into Ch07, covers from introduction to intaller & install steps.

@lei-cloud lei-cloud added the Ch 07 label Jan 8, 2020
@lei-cloud lei-cloud added this to the Snezka milestone Jan 8, 2020
@lei-cloud lei-cloud self-assigned this Jan 8, 2020
Copy link
Collaborator

@michaelfix michaelfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lei Huang (@lei-cloud ),

We have an open PR #817 for the creation of the Cook-book.

Please review PR #817 and add/edit content as needed.

NOTE, however, I would not approve your PR #888 at this time as the PR deletes the intro for the cookbook purpose, and specifically mentions the installation of K8S on the OS Cloud, and deploying ONAP using OOM. The cookbook CNTT is creating is about integration of software and components, as used in POD10 (and POD15) where we're deploying RI-1 OpenStack. The CNTT cookbook in PR #817 that Mark Beirerl (@markbeierl, email mbeierl@vmware.com) is leading will contain info about Installers, Deployment, and Initial Smoke Test, so that we have a repeatable process to setup RI.

It is possible to place the content from your PR into PR #817 , but you'd have to identify a section which would discuss orchestration/orchestrators and use ONAP as an example, not as a prescribed application that is to be used.

@markbeierl, @fuqiao123 , @rrajesh70 , @fuqiao123 - please comment, but I believe we can cancel this PR.

@rabiabdel rabiabdel changed the title Update Ch07.md [RI Ch07] Update Ch07.md Jan 9, 2020
Copy link
Collaborator

@yangyanyj yangyanyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mf4716 , about deploying ONAP using OOM section is also an example here , I suggest @lei-cloud check the current content of #817 and to see whether the content can be added and combined.

@lei-cloud
Copy link
Collaborator Author

Thanks for Mike @mf4716 and Yan @yangyanyj 's suggestions, I'll try to make the corresponding revisions and add these contents into PR # 817 in time.

@markbeierl
Copy link
Collaborator

I agree, this looks like a great start for the RI 2 cookbook as far as the K8s components go.

For the ONAP part, I don't know where it should go, as right now the RA does not specify an orchestrator. I need to see where that belongs.

@rabi-abdel rabi-abdel added this to PR Review in progress in RI1 via automation Feb 6, 2020
@rabi-abdel rabi-abdel added RI 1 and removed RI 1 Dev labels Feb 6, 2020
@rabi-abdel rabi-abdel removed this from the Snezka milestone Feb 11, 2020
@rabi-abdel
Copy link
Collaborator

@lei-cloud what is the status of this?>

@rabi-abdel
Copy link
Collaborator

rabi-abdel commented Feb 13, 2020

@lei-cloud would it be possible to create a fresh new PR for the content? the chapter names has changed (this information is now in chapter 8), and this PR is based on pretty old content. please let me know if this is ok and we can close this? @fuqiao123

@rabi-abdel
Copy link
Collaborator

based on the comments above, seems like the conclusion was to close it.

@rabi-abdel rabi-abdel closed this Feb 13, 2020
RI1 automation moved this from In progress to Done Feb 13, 2020
@rabi-abdel rabi-abdel deleted the RI-Dev-Ch07 branch February 20, 2020 12:49
@rabi-abdel rabi-abdel added the Archive Archive Item label May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Archive Archive Item
Projects
RI1
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants