Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow debug and output options to work without repo_token. #60

Merged
merged 1 commit into from Feb 18, 2015

Conversation

jessamynsmith
Copy link
Contributor

Allow debug and output options to work without repo_token, as it is not needed for these options.
Fixes #45

coagulant added a commit that referenced this pull request Feb 18, 2015
Allow debug and output options to work without repo_token.
@coagulant coagulant merged commit 646407d into TheKevJames:master Feb 18, 2015
@jessamynsmith
Copy link
Contributor Author

I didn't go that direction because kwargs as a whole are considered config:
self.config = kwargs
but if @coagulant wants I can rework the code and submit a new PR.

@esparta
Copy link

esparta commented Feb 18, 2015

Ok, now I get it.

@jessamynsmith
Copy link
Contributor Author

I think your suggestion is sensible, and was the original direction I took. Thanks for the tip!

@coagulant
Copy link
Contributor

It's ok, no need to rework. Thanks again!

@jessamynsmith
Copy link
Contributor Author

ok, cheers!

On Wed, Feb 18, 2015 at 1:09 PM, Ilya Baryshev notifications@github.com
wrote:

It's ok, no need to rework. Thanks again!


Reply to this email directly or view it on GitHub
#60 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

coveralls debug insists that a token is required
3 participants