Skip to content

Commit

Permalink
StringProcessing: Enforce full parametrization
Browse files Browse the repository at this point in the history 
To not rely on default parameters that can change, the custom
asserts do not accept default parameters anymore. With this commit
we ensure that each test will set the desired settings it wants to
check.
  • Loading branch information
@sils
Makman2 authored and sils committed Apr 15, 2015
1 parent 30a7db0 commit 4bcb859
Showing 1 changed file with 15 additions and 15 deletions.
30 changes: 15 additions & 15 deletions coalib/tests/parsing/StringProcessingTest.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -374,9 +374,9 @@ def assertSearchForResultEqual(self,
pattern,
test_strings,
expected_strings,
flags=0,
max_match=0,
use_regex=False):
flags,
max_match,
use_regex):
"""
Checks whether the given test_strings do equal the expected_strings
after feeding search_for() with them.
Expand Down Expand Up @@ -411,9 +411,9 @@ def assertSplitEquals(self,
test_strings,
expected_results,
pattern,
max_split=0,
remove_empty_matches=False,
use_regex=False):
max_split,
remove_empty_matches,
use_regex):
"""
Checks whether all supplied test strings are returned as expected from
split().
Expand Down Expand Up @@ -441,9 +441,9 @@ def assertUnescapedSplitEquals(self,
test_strings,
expected_results,
pattern,
max_split=0,
remove_empty_matches=False,
use_regex=False):
max_split,
remove_empty_matches,
use_regex):
"""
Checks whether all supplied test strings are returned as expected from
unescaped_split().
Expand Down Expand Up @@ -473,9 +473,9 @@ def assertSearchInBetweenEquals(self,
expected_results,
begin,
end,
max_match=0,
remove_empty_matches=False,
use_regex=False):
max_match,
remove_empty_matches,
use_regex):
"""
Checks whether all supplied test strings are returned as expected from
search_in_between().
Expand Down Expand Up @@ -508,9 +508,9 @@ def assertUnescapedSearchInBetweenEquals(self,
expected_results,
begin,
end,
max_match=0,
remove_empty_matches=False,
use_regex=False):
max_match,
remove_empty_matches,
use_regex):
"""
Checks whether all supplied test strings are returned as expected from
unescaped_search_in_between().
Expand Down

1 comment on commit 4bcb859

@sils
Copy link
Member

@sils sils commented on 4bcb859 Apr 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

Please sign in to comment.