Skip to content

Commit

Permalink
coala: Exit gracefully on SystemExit
Browse files Browse the repository at this point in the history
If a subroutine raises SystemExit it took care of informing the user
itself. Also we don't want to exit with 1 in case any results were
yielded or so.
  • Loading branch information
sils committed Mar 18, 2015
1 parent 4ca6cf4 commit 6972505
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion coala
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ if __name__ == "__main__":
print(_("Program terminated by user."))
exit(255)
except SystemExit:
pass
exit(0)
except:
exception = sys.exc_info()[1]
UNKNOWN_ERROR = _("An unknown error occurred.") + " " + \
Expand Down

3 comments on commit 6972505

@Udayan12167
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So issue #351 mentions exit code 0 on a succesful exit have we defined new exit code mappings?

@sils
Copy link
Member Author

@sils sils commented on 6972505 Mar 19, 2015 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Udayan12167
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack then :)

Please sign in to comment.