Skip to content

Commit

Permalink
parsing: Slyly perfect Glob coverage
Browse files Browse the repository at this point in the history
* Feel free to add a test if you can create a case in which glob tries to yield something that is neither file nor dir (symlinks get recognized as dirs)
  • Loading branch information
Fabian Neuschmidt committed Feb 5, 2015
1 parent d360739 commit 893286b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion coalib/parsing/Glob.py
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def iglob(pattern, files=True, dirs=True):
for p in selector.collect():
if os.path.isfile(p) and files is True:
yield p
elif os.path.isdir(p) and dirs is True:
elif os.path.isdir(p) and dirs is True: # pragma: nocover
yield p


Expand Down

1 comment on commit 893286b

@sils
Copy link
Member

@sils sils commented on 893286b Feb 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rejected. This also implies that the statement coverage is not measured for this branch. However you test the statement coverage here so we should measure it to ensure it remains covered.

By the way you probably want to break your long description of commit messages at the 74th char or so.

Please sign in to comment.