Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wip/dreamlined sils #229

Closed
wants to merge 7 commits into from
Closed

Wip/dreamlined sils #229

wants to merge 7 commits into from

Conversation

sils
Copy link
Member

@sils sils commented Feb 5, 2015

No description provided.

@sils sils assigned fneu Feb 5, 2015
@sils sils mentioned this pull request Feb 5, 2015
Closed
@sils sils force-pushed the wip/dreamlined_sils branch 4 times, most recently from b4152f1 to 0da0915 Compare February 5, 2015 19:52
@fneu
Copy link
Contributor

fneu commented Feb 5, 2015

@sils1297 could you please investigate why coverage/coveralls shows a coverage decrease of 38% (that's a lot!). I cannot reproduce this as my coverage on this same branch is 99%

EDIT: please post long output at pastebin or so, this is making the PR rather unviewable. Btw: I believe you :)

@fneu
Copy link
Contributor

fneu commented Feb 5, 2015

I DID add a test with two temporary files using the same procedure as in the old BearCollectorTest.

@sils
Copy link
Member Author

sils commented Feb 6, 2015

Ill investigate now. Seems if we measure coverage of the python lib itself
in the Travis environment.
Am 05.02.2015 23:52 schrieb "Fabian Neuschmidt" notifications@github.com:

I DID add a test with two temporary files using the same procedure as in
the old BearCollectorTest.

Reply to this email directly or view it on GitHub
#229 (comment).

@fneu fneu force-pushed the wip/dreamlined_sils branch 2 times, most recently from 4e37e1f to 644e25d Compare February 6, 2015 09:39
@sils
Copy link
Member Author

sils commented Feb 6, 2015

did you read my comments about the importer?

Fabian Neuschmidt and others added 7 commits February 6, 2015 15:21
tests: Update run_test.py to fix coverage
e0fdc2e
parsing: Streamline CLI Arguments
1fdf2d1 
Because of its simplicity, this commit holds several changes:

1. Removal of some CLI Arguments

We decided to use recursive globs to be able to significantly simplify
our CLI arguments and settings.

2. Removal of unneeded dest keyword arguments

If argparser has an argument --some-thing it will automatically store
this thing in some_thing. There is no need to specify this manually
every time.

3. Reformatting
ContextManager: Add suppress_stdout
a157750
Decorators: Add unique_iterating
616df47
misc: Add arguments_to_lists decorator
51453d1
@sils
Decorators: unique_iterating -> yield_once
6b74d39
collecting: Add Importers
a78401e
@sils sils added this to the 0.1 alpha milestone Feb 6, 2015
@fneu fneu closed this Feb 6, 2015
@fneu fneu deleted the wip/dreamlined_sils branch February 6, 2015 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fneu fneu

Labels
None yet
Milestone
0.1 alpha
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sils @fneu