Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

complete glob rework including fnmatch #655

Closed
wants to merge 8 commits into from
Closed

complete glob rework including fnmatch #655

wants to merge 8 commits into from

Conversation

fneu
Copy link
Contributor

@fneu fneu commented Jun 12, 2015

This PR adresses:

@fneu fneu force-pushed the wip/fneu/globlins_of_moria branch 2 times, most recently from 81c5775 to 90ac230 Compare June 12, 2015 00:53
@Makman2
Copy link
Member

Makman2 commented Jun 12, 2015

@sils1297 Could you rebuild on appveyor? Again it's too dumb and needs more than 40 minutes for a build...

@sils
Copy link
Member

sils commented Jun 13, 2015

@Makman2 let's ignore AppVeyor for now.

@fneu
Copy link
Contributor Author

fneu commented Jun 16, 2015

@Makman2 @sils1297 The "endless loop" has not been an endless loop at all. run_test() stopped at an earlier test when it was being run in the debugger, an both test were doing fine when being run separately (although they failed of course).

that is a little disturbing.

@fneu fneu force-pushed the wip/fneu/globlins_of_moria branch 3 times, most recently from b58c0a4 to 580a1c2 Compare June 17, 2015 18:28
fneu added 4 commits June 19, 2015 15:37
@fneu
Globbing: Add temporary Globbing2 module
a8450d3 
 * Globbing2 is intended to replace Globbing in-place later on
@fneu
Globbing2: Add _position_is_bracketed()
4ccbde5 
* Globbing2 is intended to replace Globbing in-place later on
@fneu
Globbing2: Add _iter_choices()
ea9c2cc 
* Globbing2 is intended to replace Globbing in-place later on
@fneu
Globbing2: Add _iter_alternatives()
9b379ce 
* Globbing2 is intended to replace Globbing in-place later on
@fneu fneu force-pushed the wip/fneu/globlins_of_moria branch from 580a1c2 to 76474cf Compare June 19, 2015 14:41
@codecov-io
Copy link

Current coverage is 99.82%

Merging #655 into master will change coverage by +0.01% by 86ee9f8

Coverage Diff

@@            master    #655   diff @@
======================================
  Files           74      74       
  Stmts         2663    2734    +71
  Branches       502     522    +20
  Methods          0       0       
======================================
+ Hit           2658    2729    +71
  Partial          5       5       
  Missed           0       0

Powered by Codecov

@fneu fneu force-pushed the wip/fneu/globlins_of_moria branch from 76474cf to cf200ce Compare June 19, 2015 15:11
@fneu fneu force-pushed the wip/fneu/globlins_of_moria branch from cf200ce to 82540de Compare June 23, 2015 06:50
@fneu
Copy link
Contributor Author

fneu commented Jun 23, 2015

There was indeed a fix missing I implemented earlier. I have no idea where it went, everything else was fine. It works for me on both systems now.

@fneu fneu force-pushed the wip/fneu/globlins_of_moria branch from 82540de to a78935a Compare June 23, 2015 10:05
fneu added 4 commits June 23, 2015 16:07
@fneu
Globbing2: Add fnmatch()
5fcbbd6 
* Globbing2 is intended to replace Globbing in-place later on
@fneu
Globbing2: Add glob() and iglob()
561c7bd 
* Globbing2 is intended to replace Globbing in-place later on
@fneu
Globbing: Switch to newer globbing solution
146eaae 
Globbing2 is replacing Globbing in-place, with minor
changes to the globbing syntax.
@fneu
Globbing: Add globbing documentation
d8017c7 
Fixes #396
@fneu fneu force-pushed the wip/fneu/globlins_of_moria branch from a78935a to d8017c7 Compare June 23, 2015 14:11
@fneu fneu added status/blocked The issue requires other referenced issues/PRs to be solved/merged before being worked on and removed process/pending review labels Jun 23, 2015
@sils
Copy link
Member

sils commented Jun 23, 2015

@fneu you workin' here?

@fneu
Copy link
Contributor Author

fneu commented Jun 23, 2015

Yes, please no review anymore today ;)

Am 23. Juni 2015 9:52:17 nachm. schrieb Lasse Schuirmann
notifications@github.com:

@fneu you workin' here?

Reply to this email directly or view it on GitHub:
#655 (comment)

@fneu
Copy link
Contributor Author

fneu commented Jun 24, 2015

superseded by #682

@fneu fneu closed this Jun 24, 2015
@fneu fneu deleted the wip/fneu/globlins_of_moria branch June 24, 2015 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status/blocked The issue requires other referenced issues/PRs to be solved/merged before being worked on status/wontfix/accepting patches
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fneu @Makman2 @sils @codecov-io