Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a default custom bear directory to check relative to project roots #2450

Open
underyx opened this issue Jul 14, 2016 · 11 comments
Open

Add a default custom bear directory to check relative to project roots #2450

underyx opened this issue Jul 14, 2016 · 11 comments

Comments

@underyx
Copy link
Member

underyx commented Jul 14, 2016

It's currently possible to set bear_dirs = .coabears to make coala pick up custom bears included with a project, but it would be better to have a default, standard location for these. My vote is for .coabears/.

@gitmate-bot
Copy link
Collaborator

Thanks for reporting this issue!

Your aid is required, fellow coalaian. Help us triage and solving this issue!

CC @sils1297, @AbdealiJK

@sils
Copy link
Member

sils commented Jul 14, 2016

My vote is for bears/, that's proper code it shouldn't be hidden IMO.

Also that setting should be relative to the coafile, right? That actually makes it kind of complicated technically...

@sils
Copy link
Member

sils commented Jul 14, 2016

let's go for .bears/?

@underyx
Copy link
Member Author

underyx commented Jul 14, 2016

I would still prefer .coabears/ to keep consistency with all the other .coathings.

@underyx
Copy link
Member Author

underyx commented Jul 14, 2016

Excerpts from gitter discussion:

  • .coabears is easier to google than .bears
  • The fact we could use .bears is just a happy coincidence cause no other project has bears. Other dotfiles are named .git + ignore, .docker + ignore, .vim + rc, .bash + rc, etc. — the .bears suggestion would break this naming scheme by making the name . + bears. Also, had they been called checks instead of bears, we'd definitely have to call it .coachecks.

@Makman2
Copy link
Member

Makman2 commented Jul 14, 2016

I'm also for coabears as it does fit better in our naming scheme imo. I like some kind of default location, so people don't need to deal with the bear-paths, for simple stuff we just say: "Put them -->there (coabears/)<--"

@underyx
Copy link
Member Author

underyx commented Jul 15, 2016

@Makman2 to clarify, is your vote for .coabears or coabears?

@underyx
Copy link
Member Author

underyx commented Jul 15, 2016

Relevant point from yesterday on gitter:

  • These bears would be configuration just like .coafile, justifying making the directory hidden. It's just configuration that's so complex that it has to be expressed with code.

@Makman2
Copy link
Member

Makman2 commented Jul 15, 2016

good question, at least I vote for the usage of this word :P
I don't really care whether we should use a period before or not^^

@adtac
Copy link
Member

adtac commented Aug 5, 2016

I like .coabears more: while it's proper code that is related to the project, it is not going to change much and it's not really related to the project. It is more of a helper for the project, like .git.

But then again there are exceptions like node_modules

@Makman2
Copy link
Member

Makman2 commented Aug 5, 2016

let's do it like git :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

6 participants