Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter: Documentation for default severity map not complete #2537

Closed
Makman2 opened this issue Jul 23, 2016 · 13 comments
Closed

Linter: Documentation for default severity map not complete #2537

Makman2 opened this issue Jul 23, 2016 · 13 comments

Comments

@Makman2
Copy link
Member

Makman2 commented Jul 23, 2016

Here: https://github.com/coala-analyzer/coala/blob/master/coalib/bearlib/abstractions/Linter.py#L686

though this is the map currently supported:

severity_map=MappingProxyType({
                    "critical": RESULT_SEVERITY.MAJOR,
                    "c": RESULT_SEVERITY.MAJOR,
                    "fatal": RESULT_SEVERITY.MAJOR,
                    "fail": RESULT_SEVERITY.MAJOR,
                    "f": RESULT_SEVERITY.MAJOR,
                    "error": RESULT_SEVERITY.MAJOR,
                    "err": RESULT_SEVERITY.MAJOR,
                    "e": RESULT_SEVERITY.MAJOR,
                    "warning": RESULT_SEVERITY.NORMAL,
                    "warn": RESULT_SEVERITY.NORMAL,
                    "w": RESULT_SEVERITY.NORMAL,
                    "information": RESULT_SEVERITY.INFO,
                    "info": RESULT_SEVERITY.INFO,
                    "i": RESULT_SEVERITY.INFO,
                    "suggestion": RESULT_SEVERITY.INFO}),
@gitmate-bot
Copy link
Collaborator

Thanks for reporting this issue! A coalaian will look at it soon.

@Adrianzatreanu
Copy link
Contributor

This issue was moved to coala/documentation#25

@Makman2
Copy link
Member Author

Makman2 commented Oct 3, 2016

Actually I just recognize I've meant the API documentation :)

@Makman2 Makman2 reopened this Oct 3, 2016
@Makman2
Copy link
Member Author

Makman2 commented Oct 3, 2016

@morganpdx wanna do this too now? This is the original issue for changing the API docs inside linter to contain the complete severity map? :)

@morganpdx
Copy link

Sure I can...but is there anything else that needs to be done?

@Makman2
Copy link
Member Author

Makman2 commented Oct 3, 2016

Nope :)

@Yomojet
Copy link

Yomojet commented Oct 6, 2016

Get me assigned!

@Makman2
Copy link
Member Author

Makman2 commented Oct 6, 2016

Ah sorry @Yomojet I forgot to assign @morganpdx , hes has already taken up on this issue (#2807)

@morganpdx
Copy link

@Makman2 Thanks! I seem to be having some trouble linting the changes properly, and it's giving me some heartburn...any advice? If I run coala on the local repo, it shows a bunch of missing bears (including 'GitCommitBear', which might be telling) so I'm not sure if there's something I'm doing wrong?

screen shot 2016-10-07 at 1 53 00 pm

@Makman2
Copy link
Member Author

Makman2 commented Oct 7, 2016

Did you install coala-bears? You won't get any bear with the default coala(-core) package^^

@morganpdx
Copy link

Thanks @Makman2, I'll give that a shot.

@morganpdx
Copy link

I installed cola-bears, and ran coala on the repo, and there appears to be no issues:

screen shot 2016-10-12 at 5 14 58 pm

However the PR is still showing issues. Is there something I'm still missing?

@Makman2
Copy link
Member Author

Makman2 commented Oct 13, 2016

PR related, I commented there :)

@rultor rultor closed this as completed in 46a3121 Nov 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants