Remove unnecessary option when DIFF_EXCERPT_MAX_SIZE is greater than 4

[Naveenaidu]

When the DIFF_EXCERPT_MAX_SIZE is greater than 4, then both Show Patch and Show Applied Patches is shown.I think one of the option needs to be removed. Since both of them show the same output. Which option needs to be removed is what needs to be discussed here?
The sample output:-

scibase-ieee-V3.py
[   1] ##·This·script·combines·both·extact_article_from·issue.py·and·Extract_Issue_Links.py
**** PEP8Bear [Section: cli | Severity: NORMAL] ****
!    ! The code does not comply to PEP8.
!    ! +1 -1 in /home/theprophet/test-coala/scibase-ieee-V3.py
[    ] *0. Do (N)othing
[    ]  1. (O)pen file
[    ]  2. (A)pply patch
[    ]  3. (S)how patch
[    ]  4. Add (I)gnore comment
[    ]  5. Show Applied (P)atches
[    ]  6. (G)enerate patches
[    ] Enter number (Ctrl-D to exit): 3

Status:- Needs Discussion.

[Naveenaidu]

cc @Makman2 Need your opinion. If this is a valid issue, Please assign me this.

[harshhx17]

Even I think that both the options are not necessary

[nityeshaga]

@Naveenaidu Can you please post the outputs of both Show Patch and Show Applied Patches for the sample?

Make sure that you execute each of them independently, i.e, you execute one then do a Ctrl-D and exit coala, then run it again, get back to the point you posted in the comment above and then execute the second action. This is to make sure that one action does not interfere with the other (because they will, if you execute ShowPatchAction before executing ShowAppliedAction in the same coala session)

[Makman2]

Sounds weird... so let's fix it.

[Naveenaidu]

@Makman2 Can i be assigned to this issue.

[Naveenaidu]

@nityeshaga If you don't mind can i please take up the issue. I have been on it for sometime and i would like to work on it. 😅

[nityeshaga]

Actually @Naveenaidu this is a difficulty/medium issue. I am afraid that you might not be qualified to solve them yet. 😅

[Naveenaidu]

@nityeshaga l'd like to give it a try 😄

[nityeshaga]

Sure, if you insist 😄

But in the end I think it is @Makman2 's decision as he is the one who assigns people to issues.

[nityeshaga]

Can you please post the outputs of both Show Patch and Show Applied Patches for the sample?

Make sure that you execute each of them independently, i.e, you execute one then do a Ctrl-D and exit coala, then run it again, get back to the point you posted in the comment above and then execute the second action. This is to make sure that one action does not interfere with the other (because they will, if you execute ShowPatchAction before executing ShowAppliedAction in the same coala session)

Also, can you please do this? I still think that the issue needs some discussion before we proceed to find its solution.

[Naveenaidu]

@nityeshaga Sorry It took me time. I had exams 😅

I executed each one seperately by exiting coala after selecting each option.

--> The sample output when (S)how Patch is selected

[----] /home/theprophet/test-coala/scibase-ieee-V3.py
[++++] /home/theprophet/test-coala/scibase-ieee-V3.py
[   1] ## This script combines both extact_article_from issue.py and Extract_Issue_Links.py
[   1] # This script combines both extact_article_from issue.py and Extract_Issue_Links.py
[    ] Displayed patch successfully.

--> The sample output when Show Applied (P)atches is selected

**** PEP8Bear [Section: cli] ****
**** Action Applied: ShowPatchAction ****

!    ! [Severity: NORMAL]
[----] /home/theprophet/test-coala/scibase-ieee-V3.py
[++++] /home/theprophet/test-coala/scibase-ieee-V3.py
[   1] ## This script combines both extact_article_from issue.py and Extract_Issue_Links.py
[   1] # This script combines both extact_article_from issue.py and Extract_Issue_Links.py

**************

[nityeshaga]

Its strange why coala shows

**** Action Applied: ShowPatchAction ****

when you select Show Applied (P)atches.

I think it should just show - All actions have been applied. - in this case

[Naveenaidu]

@nityeshaga Why do you think it's happening that way?

[nityeshaga]

That's for you to find out @Naveenaidu 😉 Run the debugger maybe.

Also be sure to get yourself assigned to this issue before you start working on it!

[Naveenaidu]

@nityeshaga Sure! I'll find the reason. And thank you for letting me take this issue 😄
@Makman2 Can i please be assigned to this issue.