getinvolved.html: string-length restriction added

[aalind0]

getinvolved.html: String-length restricted to 30.

Earlier the member bio and his commit count collided as shown below -

But after the changes it now looks like -

Closes #108

[gitmate-bot]

hey, please see coala.io/commit for the commit message, also include the issue reference. Can you give a screenshot iof how it looks? The change looks sane 👍 (I'm fine to merge it like that, being a little sloppy with this repo isn't so bad IMO)

[hemangsk]

Looks good in the screenshot, tested locally as well 👍 🎉

[hemangsk]

ack a3d68b5

[sils]

actually I'm not sure we need a limit, can we rather make the field higher? I mean the bio is quite limited already.

[aalind0]

@sils Done with the changes.

Now the bio section looks like this.

Long bio's are also accomodated now.

[meetmangukiya]

Complete bios will change the row length leading to non-uniform rows... Still we would want this ?

[aalind0]

@meetmangukiya I think we can go with complete ones now. Ya, inconsistent row-length will still be there with non uniform rows.

See this one -

@sils What do you suggest ?

[sims1253]

well we want all of them to be the same size so either have cut off bios or empty bio fields. I'd vote for cut bios but I personally don't really care about them :D

[sils]

ok let's cut them but please let them be at least three lines so most of the bios fit completely Sincerely, Lasse Schuirmann lasse@schuirmann.net http://coala.io/ - http://viperdev.io/ - http://gitmate.com/

…

On 5 February 2017 at 23:53, Maximilian Scholz ***@***.***> wrote: well we want all of them to be the same size so either have cut off bios or empty bio fields. I'd vote for cut bios but I personally don't really care about them :D — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#111 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFc6KPEWKxbPXq2OCEblFGF6tVaX012-ks5rZlMCgaJpZM4L3OPS> .

[sils]

@aalind0 if you disagree please continue discussion

[aalind0]

Bio section of each contributor now winds up in three lines.

[hemangsk]

@aalind0 it'll be great if you also post the screenshot of latest changes 😃

[aalind0]

@hemangsk Oh ! I forgot...

[gkrishnan724]

@aalind0 I would recommend not using multiple commit messages for small changes. you could use git commit --amend instead. Also, next time please create different branches for different issues :)

And we need a rebase :)

[aalind0]

@gkrishnan724 Yes, will keep that in mind from next time.

Also rebase done. 👍

[hemangsk]

wrt 5d0b64c This change is not required anymore right? as you are changing 30 -> 80 in latest commit, so you can drop 5d0b64c

[aalind0]

@hemangsk Done with the changes ! :D

[hemangsk]

👍 the present shortlog is long causing a line break and ..., you'd want to shorten it for better readability

[hemangsk]

All perfect otherwise, ready for merge! 🚀

[hemangsk]

ack e47b9b4

[hemangsk]

@rultor merge

[rultor]

@rultor merge

@hemangsk OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor merge

@hemangsk Done! FYI, the full log is here (took me 2min)