.coafile: Add IndentationBear, indent style.css #152
Conversation
|
LGTM, Two separate commit for each file will be better I think, whatsay? |
|
@hemangsk , Sure. I thought I would've been asked to squash the commits, so I made a single commit 😅 . Do I split the changes into 2 commits then ? |
|
Yeah, primarily the concept is that one commit should have only one atomic/nuclear change. So we can have two about adding the indentation bear and about correcting indentation. |
|
Hey Kaustubh, there's this tiny inconsistency in the file on this line, |
.coafile: Add IndentationBear
kaustubhhiware
force-pushed
the
indent_coafile
branch
2 times, most recently
from
1348028
to
ed102e1
Compare
|
@hemangsk All the suggested changes have been made. Line 272 has been corrected. 2 separate commits have been made to keep the changes atomic. Open for review. |
resources/css/style.css
Outdated
| padding-left: 1px; | ||
| padding-right: 1px; | ||
| float: left; | ||
| width: 33.33333333%; | ||
| } | ||
|
|
There was a problem hiding this comment.
The newline is unneeded here, right?
resources/css/style.css
Outdated
| @@ -649,15 +649,15 @@ a:hover > .card{ | |||
| } | |||
|
|
|||
|
Awesome! just two minor stuff and we're all set 🚀 🚀 |
style.css: Correct previous indentation style.css: Correct previous indentation
kaustubhhiware
force-pushed
the
indent_coafile
branch
from
ed102e1
to
92bc2a6
Compare
|
The changes have been made. Please see. |
|
@rultor merge! |
.coafile: Add IndentationBear, indent style.css
As pointed out in the gitter channel, the formatting in style.css
was mixed up.
This PR corrects my previous unintended commit.
Closes #97
For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Checklist
them.
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!
After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.
Please consider helping us by reviewing other peoples pull requests as well:
cobot mark wip <URL>to get it outof the review queue.
The more you review, the more your score will grow at coala.io and we will
review your PRs faster!