home.html: Wrap --pre in a code tag #216
Conversation
index.html
Outdated
| @@ -36,6 +36,16 @@ | |||
|
|
|||
| <link rel="shortcut icon" href="favicon.ico" type="image/x-icon"> | |||
| <script src="components/ngstorage/ngStorage.min.js"></script> | |||
| <style type="text/css"> | |||
There was a problem hiding this comment.
type Attributes: The default type for style tags is "text/css" so it can be safely omitted: Remove the type attribute from the style tag.
Origin: HTMLLintBear, Section: html.
gabru-md
changed the title
index.html
Outdated
| @@ -36,6 +36,7 @@ | |||
|
|
|||
| <link rel="shortcut icon" href="favicon.ico" type="image/x-icon"> | |||
| <script src="components/ngstorage/ngStorage.min.js"></script> | |||
| <link rel="stylesheet" type="text/css" href="resources/css/code.css"> | |||
There was a problem hiding this comment.
type Attributes: The default type for link tags is "text/css" so it can be safely omitted: Remove the type attribute from the link tag.
Origin: HTMLLintBear, Section: html.
There was a problem hiding this comment.
Hi @gabru-md
According to the guide to writing good commit messages, each commit message should have three distinct parts, a shortlog, the commit body and the issue reference.
Here's how you should write the shortlog. It is a short description of your change. Right now, your shortlog contains the issue reference. You could change it to something like just
Change pre to code tags in install section.
Here's a guide to writing a good commit message body. A slightly detailed description of the change you're making. Maybe something like
Encloses the -pre part with code tags.
Finally, your commit should contain the issue reference. Right now, it's in your PR title and in the shortlog. It should be shifted to this section. Something like
Closes https://github.com/coala/landing-frontend/issues/163
Here's how you can amend your commit messages.
gabru-md
changed the title
|
ack 0042f71 |
|
Tags were changed on index page and about page. |
|
@hemangsk Please Review |
|
Hey @gabru-md , really sorry for delay in the review I was badly stuck in some university work. Actually looking at the screenshot, using code tag is definitely changing the overall feel, imo pre was better, but I think maybe Adhityaa had something else in mind? ping @adtac, could you please take a look on this when you get some time? |
|
Oh no, I think you've misunderstood my issue. You see the "You can append --pre to that command to get the latest prerelease straight from master!" line in the homepage? The "--pre" part of the line should be within a code tag. That's it. I didn't mean to ask to change all the code elements - just change the "--pre" part to: Apologies if it was unclear. |
|
@adtac okay! |
gabru-md
changed the title
|
The tone of your commit message needs to be fixed. Use shortlog
No need for an extra repetitive sentence in the commit body Just a blank line and the |
gabru-md
force-pushed
the
master
branch
2 times, most recently
from
3985e29
to
84d5c86
Compare
gabru-md
changed the title
|
ack 450b2a4 |
|
@rultor merge |
For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Checklist
them.
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!
After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.
Please consider helping us by reviewing other peoples pull requests as well:
cobot mark wip <URL>to get it outof the review queue.
The more you review, the more your score will grow at coala.io and we will
review your PRs faster!