Make copyright year dynamic in coala.io #291

Vaibhav911 · 2018-10-27T10:12:02Z

This entrypoint ensures copyright year in foot of coala.io updates every
year automatically.
This helps in not updating the same every year.
Closes #290

includes/footer.html

jayvdb · 2018-10-27T10:14:55Z

includes/footer.html

+            <span class="left">© 
+                <script>
+                    document.write(new Date().getFullYear());
+                </script> 


Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: spacing.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpr9xhq323/includes/footer.html +++ b/tmp/tmpr9xhq323/includes/footer.html @@ -63,7 +63,7 @@ <span class="left">© <script> document.write(new Date().getFullYear()); - </script> + </script> coala </span> <a class="grey-text text-lighten-4 right" href="#!">GNU AGPL v3.0</a>

jayvdb · 2018-10-27T10:14:56Z

includes/footer.html

@@ -60,7 +60,12 @@ <h5 class="white-text fine">coala</h5>
    </div>
    <div class="footer-copyright">
        <div class="container">
-            <span class="left">© 2017 coala</span>
+            <span class="left">© 


Trailing Whitespace: Trailing white spaces are unnecessary and can complicate diffs: Remove the ' ' at the end of the line.

Origin: HTMLLintBear, Section: html.

jayvdb · 2018-10-27T10:14:57Z

includes/footer.html

+            <span class="left">© 
+                <script>
+                    document.write(new Date().getFullYear());
+                </script> 


Trailing Whitespace: Trailing white spaces are unnecessary and can complicate diffs: Remove the ' ' at the end of the line.

Origin: HTMLLintBear, Section: html.

TravisBuddy · 2018-10-27T10:15:20Z

Travis tests have failed

Hey @Vaibhav911,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

docker run -v=$(pwd):/app --workdir=/app coala/base coala --ci

Unable to find image 'coala/base:latest' locally
latest: Pulling from coala/base
















Digest: sha256:125d6cf24929d39db47b3ccd83d6ed1b6a231fc7e8afbf70bc4b5bd87653b0ff
Status: Downloaded newer image for coala/base:latest
Executing section global...
Executing section linecount...
Executing section spacing...
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Trailing whitespaces.
|----|    | /app/includes/footer.html
|    |++++| /app/includes/footer.html
|  60|  60|     </div>
|  61|  61|     <div class="footer-copyright">
|  62|  62|         <div class="container">
|  63|    |-            <span class="left">© 
|    |  63|+            <span class="left">©
|  64|  64|                 <script>
|  65|  65|                     document.write(new Date().getFullYear());
|  66|  66|                 </script> 
[INFO][10:15:09] Applied 'ShowPatchAction' on 'includes/footer.html' from 'SpaceConsistencyBear'.
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Trailing whitespaces.
|----|    | /app/includes/footer.html
|    |++++| /app/includes/footer.html
|  63|  63|             <span class="left">© 
|  64|  64|                 <script>
|  65|  65|                     document.write(new Date().getFullYear());
|  66|    |-                </script> 
|    |  66|+                </script>
|  67|  67|                 coala
|  68|  68|             </span>
|  69|  69|             <a class="grey-text text-lighten-4 right" href="#!">GNU AGPL v3.0</a>
[INFO][10:15:09] Applied 'ShowPatchAction' on 'includes/footer.html' from 'SpaceConsistencyBear'.
Executing section html...
[WARNING][10:15:10] HTMLLintBear: This result has no patch attached.
[WARNING][10:15:10] HTMLLintBear: This result has no patch attached.

includes/footer.html
|  63| ············<span·class="left">©·
|    | [MAJOR] HTMLLintBear:
|    | Trailing Whitespace: Trailing white spaces are unnecessary and can complicate diffs: Remove the ' ' at the end of the line.

includes/footer.html
|  66| ················</script>·
|    | [MAJOR] HTMLLintBear:
|    | Trailing Whitespace: Trailing white spaces are unnecessary and can complicate diffs: Remove the ' ' at the end of the line.
Executing section yml...
Executing section cli...

TravisBuddy Request Identifier: 30f49e10-d9d1-11e8-a99b-eb776290c7c8

jayvdb · 2018-10-27T10:47:39Z

includes/footer.html

@@ -60,7 +60,12 @@ <h5 class="white-text fine">coala</h5>
    </div>
    <div class="footer-copyright">
        <div class="container">
-            <span class="left">© 2017 coala</span>
+            <span class="left">© 


Trailing Whitespace: Trailing white spaces are unnecessary and can complicate diffs: Remove the ' ' at the end of the line.

Origin: HTMLLintBear, Section: html.

jayvdb · 2018-10-27T10:47:40Z

includes/footer.html

+            <span class="left">© 
+                <script>
+                    document.write(new Date().getFullYear());
+                </script> 


Trailing Whitespace: Trailing white spaces are unnecessary and can complicate diffs: Remove the ' ' at the end of the line.

Origin: HTMLLintBear, Section: html.

jayvdb · 2018-10-27T10:47:40Z

includes/footer.html

@@ -60,7 +60,12 @@ <h5 class="white-text fine">coala</h5>
    </div>
    <div class="footer-copyright">
        <div class="container">
-            <span class="left">© 2017 coala</span>
+            <span class="left">© 


Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: spacing.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpr9xhq323/includes/footer.html +++ b/tmp/tmpr9xhq323/includes/footer.html @@ -60,7 +60,7 @@ </div> <div class="footer-copyright"> <div class="container"> - <span class="left">© + <span class="left">© <script> document.write(new Date().getFullYear()); </script>

jayvdb · 2018-10-27T10:47:41Z

includes/footer.html

+            <span class="left">© 
+                <script>
+                    document.write(new Date().getFullYear());
+                </script> 


Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: spacing.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpr9xhq323/includes/footer.html +++ b/tmp/tmpr9xhq323/includes/footer.html @@ -63,7 +63,7 @@ <span class="left">© <script> document.write(new Date().getFullYear()); - </script> + </script> coala </span> <a class="grey-text text-lighten-4 right" href="#!">GNU AGPL v3.0</a>

Vaibhav911 · 2018-10-27T11:24:50Z

Can someone clarify why it is showing this PR has issues?
I have removed all the trailing white spaces.

Tyroc · 2018-10-27T13:23:25Z

Can't really help with the whitespace problem, but I think that the code in itself is not working. If i try your exact solution, my whole page gets overwritten and only the new Date is being displayed. However in the following solution everything works fine:

<span class="left">
    &copy;
    <span id="copyright">
        <script>document.getElementById('copyright').appendChild(document.createTextNode(new Date().getFullYear()))</script>
    </span>
    coala
</span>

Maybe try that.

srivama

You need to squash both your commits into one. Please refer to coala.io/git for the same. Also, edit your commit message after squashing, using git commit -a --amend and write a more appropriate description. Entrypoint was used in the example with respect to bears and isn't required here:wink:

includes/footer.html

Vaibhav911 · 2018-10-27T16:04:10Z

@Tyroc Thnx for your suggestion. But your code is producing same output as mine in my machine. I have just changed the year part of the code. Rest html page is still the same. I don't know why your whole page is being overwritten with my code. Please correct me if I am wrong anywhere. Thnx once again.

Tyroc · 2018-10-27T16:37:29Z

@Vaibhav911 Then there must be a problem with my machine. Sorry! Good contribution btw.

Vaibhav911 · 2018-10-28T03:32:47Z

@Tyroc, I guess you were right. if I run document.write after the document has loaded ,it overwrite the whole page. If it is run before that, it does not overwrite it. So I am using a little different approach now. Thank you so much for pointing out my mistake. I will correct it soon.

jayvdb · 2018-10-28T05:31:32Z

includes/footer.html

@@ -60,7 +60,12 @@ <h5 class="white-text fine">coala</h5>
    </div>
    <div class="footer-copyright">
        <div class="container">
-            <span class="left">© 2017 coala</span>
+            <span class="left">© 


Trailing Whitespace: Trailing white spaces are unnecessary and can complicate diffs: Remove the ' ' at the end of the line.

Origin: HTMLLintBear, Section: html.

jayvdb · 2018-10-28T05:31:33Z

includes/footer.html

+            <span class="left">© 
+                <script>
+                    document.write(new Date().getFullYear());
+                </script> 


Trailing Whitespace: Trailing white spaces are unnecessary and can complicate diffs: Remove the ' ' at the end of the line.

Origin: HTMLLintBear, Section: html.

jayvdb · 2018-10-28T05:31:34Z

includes/footer.html

@@ -60,7 +60,12 @@ <h5 class="white-text fine">coala</h5>
    </div>
    <div class="footer-copyright">
        <div class="container">
-            <span class="left">© 2017 coala</span>
+            <span class="left">© 


Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: spacing.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpr9xhq323/includes/footer.html +++ b/tmp/tmpr9xhq323/includes/footer.html @@ -60,7 +60,7 @@ </div> <div class="footer-copyright"> <div class="container"> - <span class="left">© + <span class="left">© <script> document.write(new Date().getFullYear()); </script>

jayvdb · 2018-10-28T05:31:35Z

includes/footer.html

+            <span class="left">© 
+                <script>
+                    document.write(new Date().getFullYear());
+                </script> 


Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: spacing.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpr9xhq323/includes/footer.html +++ b/tmp/tmpr9xhq323/includes/footer.html @@ -63,7 +63,7 @@ <span class="left">© <script> document.write(new Date().getFullYear()); - </script> + </script> coala </span> <a class="grey-text text-lighten-4 right" href="#!">GNU AGPL v3.0</a>

TravisBuddy · 2018-10-28T05:32:29Z

Travis tests have failed

Hey @Vaibhav911,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

docker run -v=$(pwd):/app --workdir=/app coala/base coala --ci

Unable to find image 'coala/base:latest' locally
latest: Pulling from coala/base
















Digest: sha256:125d6cf24929d39db47b3ccd83d6ed1b6a231fc7e8afbf70bc4b5bd87653b0ff
Status: Downloaded newer image for coala/base:latest
Executing section global...
Executing section linecount...
Executing section spacing...
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Tabs used instead of spaces.
|----|    | /app/includes/footer.html
|    |++++| /app/includes/footer.html
|  61|  61|     <div class="footer-copyright">
|  62|  62|         <div class="container">
|  63|  63|             <span class="left">
|  64|    |-	        ©
|    |  64|+            ©
|  65|  65| 		<script>
|  66|  66| 		    document.getElementById("current-year").innerHTML=new Date().getFullYear();
|  67|  67| 		</script>
[INFO][05:32:13] Applied 'ShowPatchAction' on 'includes/footer.html' from 'SpaceConsistencyBear'.
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Tabs used instead of spaces.
|----|    | /app/includes/footer.html
|    |++++| /app/includes/footer.html
|  62|  62|         <div class="container">
|  63|  63|             <span class="left">
|  64|  64| 	        ©
|  65|    |-		<script>
|    |  65|+        <script>
|  66|  66| 		    document.getElementById("current-year").innerHTML=new Date().getFullYear();
|  67|  67| 		</script>
|  68|  68| 		<span id="current-year"></span>
[INFO][05:32:13] Applied 'ShowPatchAction' on 'includes/footer.html' from 'SpaceConsistencyBear'.
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Tabs used instead of spaces.
|----|    | /app/includes/footer.html
|    |++++| /app/includes/footer.html
|  63|  63|             <span class="left">
|  64|  64| 	        ©
|  65|  65| 		<script>
|  66|    |-		    document.getElementById("current-year").innerHTML=new Date().getFullYear();
|    |  66|+            document.getElementById("current-year").innerHTML=new Date().getFullYear();
|  67|  67| 		</script>
|  68|  68| 		<span id="current-year"></span>
|  69|  69|                 coala
[INFO][05:32:13] Applied 'ShowPatchAction' on 'includes/footer.html' from 'SpaceConsistencyBear'.
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Tabs used instead of spaces.
|----|    | /app/includes/footer.html
|    |++++| /app/includes/footer.html
|  64|  64| 	        ©
|  65|  65| 		<script>
|  66|  66| 		    document.getElementById("current-year").innerHTML=new Date().getFullYear();
|  67|    |-		</script>
|    |  67|+        </script>
|  68|  68| 		<span id="current-year"></span>
|  69|  69|                 coala
|  70|  70|             </span>
[INFO][05:32:13] Applied 'ShowPatchAction' on 'includes/footer.html' from 'SpaceConsistencyBear'.
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Tabs used instead of spaces.
|----|    | /app/includes/footer.html
|    |++++| /app/includes/footer.html
|  65|  65| 		<script>
|  66|  66| 		    document.getElementById("current-year").innerHTML=new Date().getFullYear();
|  67|  67| 		</script>
|  68|    |-		<span id="current-year"></span>
|    |  68|+        <span id="current-year"></span>
|  69|  69|                 coala
|  70|  70|             </span>
|  71|  71|             <a class="grey-text text-lighten-4 right" href="#!">GNU AGPL v3.0</a>
[INFO][05:32:13] Applied 'ShowPatchAction' on 'includes/footer.html' from 'SpaceConsistencyBear'.
Executing section html...
[WARNING][05:32:13] HTMLLintBear: This result has no patch attached.
[WARNING][05:32:13] HTMLLintBear: This result has no patch attached.
[WARNING][05:32:13] HTMLLintBear: This result has no patch attached.
[WARNING][05:32:13] HTMLLintBear: This result has no patch attached.
[WARNING][05:32:13] HTMLLintBear: This result has no patch attached.

includes/footer.html
|  64| »   ········©
|    | [MAJOR] HTMLLintBear:
|    | Indentation: Do not use tabs: Remove the tabs.

includes/footer.html
|  65| »   »   <script>
|    | [MAJOR] HTMLLintBear:
|    | Indentation: Do not use tabs: Remove the tabs.

includes/footer.html
|  66| »   »   ····document.getElementById("current-year").innerHTML=new·Date().getFullYear();
|    | [MAJOR] HTMLLintBear:
|    | Indentation: Do not use tabs: Remove the tabs.

includes/footer.html
|  67| »   »   </script>
|    | [MAJOR] HTMLLintBear:
|    | Indentation: Do not use tabs: Remove the tabs.

includes/footer.html
|  68| »   »   <span·id="current-year"></span>
|    | [MAJOR] HTMLLintBear:
|    | Indentation: Do not use tabs: Remove the tabs.
Executing section yml...
Executing section cli...

TravisBuddy Request Identifier: d479d040-da72-11e8-8964-ad637cdcaaf8

jayvdb · 2018-10-28T05:54:32Z

includes/footer.html

@@ -60,7 +60,12 @@ <h5 class="white-text fine">coala</h5>
    </div>
    <div class="footer-copyright">
        <div class="container">
-            <span class="left">© 2017 coala</span>
+            <span class="left">© 


Trailing Whitespace: Trailing white spaces are unnecessary and can complicate diffs: Remove the ' ' at the end of the line.

Origin: HTMLLintBear, Section: html.

jayvdb · 2018-10-28T05:54:33Z

includes/footer.html

+            <span class="left">© 
+                <script>
+                    document.write(new Date().getFullYear());
+                </script> 


Trailing Whitespace: Trailing white spaces are unnecessary and can complicate diffs: Remove the ' ' at the end of the line.

Origin: HTMLLintBear, Section: html.

jayvdb · 2018-10-28T05:54:34Z

includes/footer.html

@@ -60,7 +60,12 @@ <h5 class="white-text fine">coala</h5>
    </div>
    <div class="footer-copyright">
        <div class="container">
-            <span class="left">© 2017 coala</span>
+            <span class="left">© 


Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: spacing.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpr9xhq323/includes/footer.html +++ b/tmp/tmpr9xhq323/includes/footer.html @@ -60,7 +60,7 @@ </div> <div class="footer-copyright"> <div class="container"> - <span class="left">© + <span class="left">© <script> document.write(new Date().getFullYear()); </script>

jayvdb · 2018-10-28T05:54:34Z

includes/footer.html

+            <span class="left">© 
+                <script>
+                    document.write(new Date().getFullYear());
+                </script> 


Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: spacing.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpr9xhq323/includes/footer.html +++ b/tmp/tmpr9xhq323/includes/footer.html @@ -63,7 +63,7 @@ <span class="left">© <script> document.write(new Date().getFullYear()); - </script> + </script> coala </span> <a class="grey-text text-lighten-4 right" href="#!">GNU AGPL v3.0</a>

jayvdb · 2018-10-28T05:56:15Z

includes/footer.html

+	        ©
+		<script>
+		    document.getElementById("current-year").innerHTML=new Date().getFullYear();
+		</script>


Line contains following spacing inconsistencies:

Tabs used instead of spaces.

Origin: SpaceConsistencyBear, Section: spacing.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpl9zy7y_2/includes/footer.html +++ b/tmp/tmpl9zy7y_2/includes/footer.html @@ -61,7 +61,7 @@ <div class="footer-copyright"> <div class="container"> <span class="left"> - © + © <script> document.getElementById("current-year").innerHTML=new Date().getFullYear(); </script>

jayvdb · 2018-10-29T04:20:35Z

@gitmate-bot ff

jayvdb · 2018-10-29T04:20:37Z

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently ⚠️

jayvdb · 2018-10-29T04:21:29Z

Automated fastforward with GitMate.io was successful! 🎉

This entrypoint ensures copyright year in foot of coala.io updates every year automatically. This helps in not updating the same every year. Closes coala#290

jayvdb added process/pending review size/XS difficulty/newcomer type/bug labels Oct 27, 2018

jayvdb reviewed Oct 27, 2018

View reviewed changes

includes/footer.html Outdated Show resolved Hide resolved

jayvdb reviewed Oct 27, 2018

View reviewed changes

srivama reviewed Oct 27, 2018

View reviewed changes

includes/footer.html Show resolved Hide resolved

jayvdb reviewed Oct 28, 2018

View reviewed changes

jayvdb added the process/approved label Oct 29, 2018

jayvdb merged commit 2759b0f into coala:master Oct 29, 2018

jayvdb removed the process/approved label Oct 29, 2018

jayvdb deployed to github-pages October 29, 2018 04:21 View deployment

Make copyright year dynamic in coala.io

2759b0f

This entrypoint ensures copyright year in foot of coala.io updates every year automatically. This helps in not updating the same every year. Closes coala#290

jayvdb added the process/approved label Oct 29, 2018

Vaibhav911 deleted the patch-1 branch October 29, 2018 05:39

jayvdb added process/approved and removed process/approved labels Nov 1, 2018

jayvdb added process/approved and removed process/approved labels Nov 8, 2018

jayvdb added process/approved and removed process/approved labels Nov 15, 2018

jayvdb added process/approved and removed process/approved labels Nov 22, 2018

jayvdb added process/approved and removed process/approved labels Nov 29, 2018

jayvdb added process/approved and removed process/approved labels Dec 6, 2018

jayvdb added process/approved and removed process/approved labels Dec 13, 2018

jayvdb added process/approved and removed process/approved labels Dec 20, 2018

jayvdb added process/approved and removed process/approved labels Dec 27, 2018

jayvdb added process/approved and removed process/approved labels Jan 3, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make copyright year dynamic in coala.io #291

Make copyright year dynamic in coala.io #291

Vaibhav911 commented Oct 27, 2018 •

edited

jayvdb Oct 27, 2018

jayvdb Oct 27, 2018

jayvdb Oct 27, 2018

TravisBuddy commented Oct 27, 2018

jayvdb Oct 27, 2018

jayvdb Oct 27, 2018

jayvdb Oct 27, 2018

jayvdb Oct 27, 2018

Vaibhav911 commented Oct 27, 2018

Tyroc commented Oct 27, 2018

srivama left a comment •

edited

Vaibhav911 commented Oct 27, 2018

Tyroc commented Oct 27, 2018

Vaibhav911 commented Oct 28, 2018 •

edited

jayvdb Oct 28, 2018

jayvdb Oct 28, 2018

jayvdb Oct 28, 2018

jayvdb Oct 28, 2018

TravisBuddy commented Oct 28, 2018

jayvdb Oct 28, 2018

jayvdb Oct 28, 2018

jayvdb Oct 28, 2018

jayvdb Oct 28, 2018

jayvdb Oct 28, 2018

jayvdb commented Oct 29, 2018

jayvdb commented Oct 29, 2018

jayvdb commented Oct 29, 2018

Make copyright year dynamic in coala.io #291

Make copyright year dynamic in coala.io #291

Conversation

Vaibhav911 commented Oct 27, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TravisBuddy commented Oct 27, 2018

Travis tests have failed

1st Build

TravisBuddy Request Identifier: 30f49e10-d9d1-11e8-a99b-eb776290c7c8

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Vaibhav911 commented Oct 27, 2018

Tyroc commented Oct 27, 2018

srivama left a comment • edited

Choose a reason for hiding this comment

Vaibhav911 commented Oct 27, 2018

Tyroc commented Oct 27, 2018

Vaibhav911 commented Oct 28, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TravisBuddy commented Oct 28, 2018

Travis tests have failed

1st Build

TravisBuddy Request Identifier: d479d040-da72-11e8-8964-ad637cdcaaf8

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jayvdb commented Oct 29, 2018

jayvdb commented Oct 29, 2018

jayvdb commented Oct 29, 2018

Vaibhav911 commented Oct 27, 2018 •

edited

srivama left a comment •

edited

Vaibhav911 commented Oct 28, 2018 •

edited