Animation Under All Tabs are Working #296

AkshJain99 · 2018-12-11T11:26:02Z

Highlighting animation are working
under all tabs on navigation
between different tabs.

Fixes #295

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

I read the commit guidelines and I've followed
them.
I ran coala over my code locally. (All commits have to pass
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

pick up any PR at https://coala.io/review
review it (check https://coala.io/reviewing for more info)
if you are sure that it needs work, use cobot mark wip <URL> to get it out
of the review queue.

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

naveentvelu

Adding ul.tabs in partials/tabs/people.html is not desired. Because only five tabs are defined in index.html. And /people tab is not defined there. It would be better if we remove it.

AkshJain99 · 2018-12-13T13:06:23Z

ya but people.html is somewhere which also have this problem so maybe it is right
I will look again

AkshJain99 · 2018-12-13T14:22:03Z

@hemangsk please revirew this pr

AkshJain99 · 2018-12-16T07:48:15Z

@li-boxuan please take look at this pr

hemangsk · 2018-12-17T10:18:59Z

Is there any way to avoid the code duplication, maybe adding it by in index.html file ?

AkshJain99 · 2018-12-17T10:23:21Z

@hemangsk I tried to do so in index.html but I dont think that we will be able to do that .
Do we?
And its just 2 line of code that has been added I dont think that it is affecting the codes,Is it?
😅

AkshJain99 · 2018-12-17T10:52:05Z

@hemangsk I tried adding the script in index.html but then it doesn't work, but code which I committed is working well 😅

hemangsk · 2018-12-17T15:18:14Z

partials/tabs/people.html

+  $(document).ready(function(){
+    $('ul.tabs').tabs();
+  });
+


Extra line, can be removed

Same for all the files

@hemangsk but actually i am removing extra line then travis is failing "showing that there is no line at end of file"

Not the newline at end of file, See L42 , L281 etc.

done @hemangsk 👍

Sorry I think I wasn't clear enough, only those extra new lines which were added in this commit inside the script tags need to be omitted. Others are fine. If you feel they are extra then its a discussion for a new ticket and not this one.

So we are fine with just converting the

<script> $(document).ready(function(){ $('ul tabs').tabs(); })

to

<script> $(document).ready(function(){ $('ul tabs').tabs(); })

oh okay @hemangsk done 👍
now i think its perfectly ready for merge ,Is there still any changes?

hemangsk · 2018-12-17T15:21:13Z

Ya I understand, Two lines or one lines is not the point, duplication makes maintaining it difficult. Otherwise, this lgtm.

AkshJain99 · 2018-12-17T15:29:22Z

okay @hemangsk I am understanding, then should i need to change something in code?

jayvdb · 2018-12-17T15:44:10Z

partials/tabs/coalaonline.html

+  $('ul.tabs').tabs();
+});
+
+</script>


Line contains following spacing inconsistencies:

No newline at EOF.

Origin: SpaceConsistencyBear, Section: spacing.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp8v872ato/partials/tabs/coalaonline.html +++ b/tmp/tmp8v872ato/partials/tabs/coalaonline.html @@ -279,4 +279,4 @@ $('ul.tabs').tabs(); }); -</script>+</script>

jayvdb · 2018-12-17T15:44:11Z

partials/tabs/languages.html

@@ -219,4 +220,4 @@
    $('.tooltipped').tooltip({delay: 50});

    })
-</script>
+</script>


Line contains following spacing inconsistencies:

No newline at EOF.

Origin: SpaceConsistencyBear, Section: spacing.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp8v872ato/partials/tabs/languages.html +++ b/tmp/tmp8v872ato/partials/tabs/languages.html @@ -220,4 +220,4 @@ $('.tooltipped').tooltip({delay: 50}); }) -</script>+</script>

jayvdb · 2018-12-17T15:44:12Z

partials/tabs/home.html

+  $('ul.tabs').tabs();
+});
+
+</script>


Line contains following spacing inconsistencies:

No newline at EOF.

Origin: SpaceConsistencyBear, Section: spacing.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp8v872ato/partials/tabs/home.html +++ b/tmp/tmp8v872ato/partials/tabs/home.html @@ -136,4 +136,4 @@ $('ul.tabs').tabs(); }); -</script>+</script>

jayvdb · 2018-12-17T15:44:13Z

partials/tabs/about.html

@@ -129,4 +129,4 @@ <h2 class="fine center">about</h2>
  $('ul.tabs').tabs();
 });

-</script>
+</script>


Line contains following spacing inconsistencies:

No newline at EOF.

Origin: SpaceConsistencyBear, Section: spacing.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp8v872ato/partials/tabs/about.html +++ b/tmp/tmp8v872ato/partials/tabs/about.html @@ -129,4 +129,4 @@ $('ul.tabs').tabs(); }); -</script>+</script>

jayvdb · 2018-12-17T15:44:14Z

partials/tabs/getinvolved.html

+    $('ul.tabs').tabs();
+});
+
+</script>


Line contains following spacing inconsistencies:

No newline at EOF.

Origin: SpaceConsistencyBear, Section: spacing.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp8v872ato/partials/tabs/getinvolved.html +++ b/tmp/tmp8v872ato/partials/tabs/getinvolved.html @@ -82,4 +82,4 @@ $('ul.tabs').tabs(); }); -</script>+</script>

TravisBuddy · 2018-12-17T15:44:34Z

Travis tests have failed

Hey @AkshJain99,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

docker run -v=$(pwd):/app --workdir=/app coala/base coala --ci

Unable to find image 'coala/base:latest' locally
latest: Pulling from coala/base
















Digest: sha256:125d6cf24929d39db47b3ccd83d6ed1b6a231fc7e8afbf70bc4b5bd87653b0ff
Status: Downloaded newer image for coala/base:latest
Executing section global...
Executing section linecount...
Executing section spacing...
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - No newline at EOF.
|----|    | /app/partials/tabs/home.html
|    |++++| /app/partials/tabs/home.html
| 136| 136|   $('ul.tabs').tabs();
| 137| 137| });
| 138| 138| 
| 139|    |-</script>
|    | 139|+</script>
[INFO][15:44:27] Applied 'ShowPatchAction' on 'partials/tabs/home.html' from 'SpaceConsistencyBear'.
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - No newline at EOF.
|----|    | /app/partials/tabs/getinvolved.html
|    |++++| /app/partials/tabs/getinvolved.html
|  82|  82|     $('ul.tabs').tabs();
|  83|  83| });
|  84|  84| 
|  85|    |-</script>
|    |  85|+</script>
[INFO][15:44:27] Applied 'ShowPatchAction' on 'partials/tabs/getinvolved.html' from 'SpaceConsistencyBear'.
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - No newline at EOF.
|----|    | /app/partials/tabs/coalaonline.html
|    |++++| /app/partials/tabs/coalaonline.html
| 279| 279|   $('ul.tabs').tabs();
| 280| 280| });
| 281| 281| 
| 282|    |-</script>
|    | 282|+</script>
[INFO][15:44:27] Applied 'ShowPatchAction' on 'partials/tabs/coalaonline.html' from 'SpaceConsistencyBear'.
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - No newline at EOF.
|----|    | /app/partials/tabs/languages.html
|    |++++| /app/partials/tabs/languages.html
| 220| 220|     $('.tooltipped').tooltip({delay: 50});
| 221| 221| 
| 222| 222|     })
| 223|    |-</script>
|    | 223|+</script>
[INFO][15:44:27] Applied 'ShowPatchAction' on 'partials/tabs/languages.html' from 'SpaceConsistencyBear'.
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - No newline at EOF.
|----|    | /app/partials/tabs/about.html
|    |++++| /app/partials/tabs/about.html
| 129| 129|   $('ul.tabs').tabs();
| 130| 130| });
| 131| 131| 
| 132|    |-</script>
|    | 132|+</script>
[INFO][15:44:27] Applied 'ShowPatchAction' on 'partials/tabs/about.html' from 'SpaceConsistencyBear'.
Executing section html...
Executing section yml...
Executing section cli...

TravisBuddy Request Identifier: a48c5d40-0212-11e9-819e-e174a5d00ea5

Highlighting animation are working under all tabs on navigation between different tabs. Fixes coala#295

hemangsk · 2018-12-18T07:46:59Z

ack 88f354e

jayvdb · 2019-01-04T13:52:19Z

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently ⚠️

jayvdb · 2019-01-04T13:53:20Z

Automated fastforward with GitMate.io was successful! 🎉

jayvdb added process/pending review size/XS difficulty/low type/bug labels Dec 11, 2018

jayvdb assigned AkshJain99 Dec 11, 2018

li-boxuan requested a review from hemangsk December 11, 2018 11:45

naveentvelu reviewed Dec 13, 2018

View reviewed changes

hemangsk reviewed Dec 17, 2018

View reviewed changes

AkshJain99 force-pushed the animation branch from a6deb02 to 0eebd10 Compare December 17, 2018 15:42

jayvdb reviewed Dec 17, 2018

View reviewed changes

AkshJain99 force-pushed the animation branch 2 times, most recently from c838a23 to 65b23b6 Compare December 17, 2018 17:15

Animation Under All Tabs are Working

88f354e

Highlighting animation are working under all tabs on navigation between different tabs. Fixes coala#295

AkshJain99 force-pushed the animation branch from 65b23b6 to 88f354e Compare December 17, 2018 18:57

jayvdb added process/approved and removed process/pending review labels Dec 18, 2018

jayvdb merged commit 88f354e into coala:master Jan 4, 2019

jayvdb removed the process/approved label Jan 4, 2019

jayvdb deployed to github-pages January 4, 2019 13:53 View deployment

jayvdb added process/approved and removed process/approved labels Jan 4, 2019

jayvdb added process/approved and removed process/approved labels Jan 17, 2019

jayvdb added process/approved and removed process/approved labels Jan 24, 2019

jayvdb added process/approved and removed process/approved labels Jan 31, 2019

jayvdb added process/approved and removed process/approved labels Feb 7, 2019

jayvdb added process/approved and removed process/approved labels Feb 14, 2019

jayvdb added process/approved and removed process/approved labels Feb 21, 2019

jayvdb added process/approved and removed process/approved labels Feb 28, 2019

jayvdb added process/approved and removed process/approved labels Mar 7, 2019

jayvdb added process/approved and removed process/approved labels Mar 14, 2019

jayvdb added process/approved and removed process/approved labels Mar 21, 2019

jayvdb added process/approved and removed process/approved labels Mar 28, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Animation Under All Tabs are Working #296

Animation Under All Tabs are Working #296

AkshJain99 commented Dec 11, 2018 •

edited

naveentvelu left a comment

AkshJain99 commented Dec 13, 2018

AkshJain99 commented Dec 13, 2018

AkshJain99 commented Dec 16, 2018

hemangsk commented Dec 17, 2018

AkshJain99 commented Dec 17, 2018

AkshJain99 commented Dec 17, 2018 •

edited

hemangsk Dec 17, 2018

hemangsk Dec 17, 2018

AkshJain99 Dec 17, 2018 •

edited

hemangsk Dec 17, 2018

AkshJain99 Dec 17, 2018

hemangsk Dec 17, 2018

AkshJain99 Dec 17, 2018 •

edited

hemangsk commented Dec 17, 2018

AkshJain99 commented Dec 17, 2018

jayvdb Dec 17, 2018

jayvdb Dec 17, 2018

jayvdb Dec 17, 2018

jayvdb Dec 17, 2018

jayvdb Dec 17, 2018

TravisBuddy commented Dec 17, 2018

hemangsk commented Dec 18, 2018

jayvdb commented Jan 4, 2019

jayvdb commented Jan 4, 2019

Animation Under All Tabs are Working #296

Animation Under All Tabs are Working #296

Conversation

AkshJain99 commented Dec 11, 2018 • edited

Checklist

naveentvelu left a comment

Choose a reason for hiding this comment

AkshJain99 commented Dec 13, 2018

AkshJain99 commented Dec 13, 2018

AkshJain99 commented Dec 16, 2018

hemangsk commented Dec 17, 2018

AkshJain99 commented Dec 17, 2018

AkshJain99 commented Dec 17, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AkshJain99 Dec 17, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AkshJain99 Dec 17, 2018 • edited

Choose a reason for hiding this comment

hemangsk commented Dec 17, 2018

AkshJain99 commented Dec 17, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TravisBuddy commented Dec 17, 2018

Travis tests have failed

1st Build

TravisBuddy Request Identifier: a48c5d40-0212-11e9-819e-e174a5d00ea5

hemangsk commented Dec 18, 2018

jayvdb commented Jan 4, 2019

jayvdb commented Jan 4, 2019

AkshJain99 commented Dec 11, 2018 •

edited

AkshJain99 commented Dec 17, 2018 •

edited

AkshJain99 Dec 17, 2018 •

edited

AkshJain99 Dec 17, 2018 •

edited