Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch arg parsing to clap-derive #78

Merged
merged 2 commits into from Aug 23, 2022

Conversation

tranzystorekk
Copy link
Contributor

Hi, I recently discovered this project and would love to have a proper TUI display manager in my leftwm config, so I thought I'd contribute.

This PR changes the clap API to the derive version, which should eliminate some boilerplate code.

Notable changes (to be adjusted/reverted at your discretion):

  • switch around some function signatures to use &Path instead of raw &str
  • rename --nolog flag to --no-log

@coastalwhite
Copy link
Owner

Thank you very much. These look like good cleanup changes. I took the liberty of running cargo fmt and then merged.

Apart from this PR is there any changes you want to see prioritized? I will probably work some more on this project starting in September, so then I will probably look at adding Wayland and terminal support.

@coastalwhite coastalwhite merged commit fb77dd3 into coastalwhite:develop Aug 23, 2022
@tranzystorekk tranzystorekk deleted the clap-derive branch August 23, 2022 19:00
@tranzystorekk
Copy link
Contributor Author

tranzystorekk commented Aug 23, 2022

So far I've been trying to build and run this for Void Linux, so my main aim is to create a runit script that successfuly starts lemurs, so far no success.

It would also be nice for lemurs to be able to detect xsession/wayland session files installed in the system and run sessions from them.

So far, from all the "minimalist" DMs I've tried, only emptty can decently read xsession files and start a proper x configuration from them.

@coastalwhite
Copy link
Owner

Could you try adapting some of the work done for ly (e.g. here). But, maybe you already looked at those.

If you get it to work let me know, I would love to include that in the installation files.

coastalwhite added a commit that referenced this pull request Nov 22, 2022
* Caching Post-Login Environment (#75)

* Add a configuration option for focus behaviour (#74)

* Add a configuration option for focus behaviour

* Rust fmt

* Add caching for post login environment

* Fmt

* Clippy

* Fix the status message (#77)

* Fix status message
* Handle render unwraps
* Add comment
* FMT and Clippy

* Switch arg parsing to clap-derive (#78)

* Switch arg parsing to clap-derive
* RustFmt

Co-authored-by: Gijs Burghoorn <g.burghoorn@gmail.com>

* Make nightly the default toolchain

* Enable building with stable toolchain (#79)

* Adjust code so that it builds with stable Rust
* Move unsafety to only wrap the 'pre_exec'
* Fix PERMERR by reordering to set{groups, gid, uid}
* Remove +nightly from install script

Co-authored-by: Gijs Burghoorn <g.burghoorn@gmail.com>

* Add command to show possible environments

* Exclude non-executable environments

* Add subcommand to view cached information

* Add --tty CLI flag to override TTY configuration (#81)

* Add TTY Shell environment (#82)

Add TTY shell environment

* Always display TTYSHELL if no wms are found (#83)

* Add AUR installation instructions (#87)

* File overview in README (#88)

Add file overview in README

* [FIX]: Show TTY Shell on dir misconfiguration (#89)

* Wayland support (#84)

* Get started on wayland support

* Add AUR installation instructions (#87)

* File overview in README (#88)

Add file overview in README

* Working Wayland

* Improve the README to reflect changes

* Version Bump and Document Dependencies

* Change power control commands to systemd

* Change cover image

* Crop cover image

* [FEATURE]: Add UTMPX support

* RUSTFMT and add libc dependency

* UTMPX Support (#90)

* [FEATURE]: Add UTMPX support
* RUSTFMT and add libc dependency

* Clippy and include Cargo.lock

Co-authored-by: Marcin Puc <tranzystorek.io@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants