Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaking warning triggers on R-devel post Nov 1st #13

Closed
coatless opened this issue Nov 4, 2023 · 1 comment · Fixed by #14
Closed

Leaking warning triggers on R-devel post Nov 1st #13

coatless opened this issue Nov 4, 2023 · 1 comment · Fixed by #14

Comments

@coatless
Copy link
Collaborator

coatless commented Nov 4, 2023

From the R-devel build on Wed, 01 Nov 23:

‘warnings()’ now always inherits from ‘"warnings"’ as documented, newly also in the case of no warnings, where it previously returned ‘NULL’.

This is causing empty warnings to be triggered on the r-devel check

CRAN R-Devel Checks
Version: 0.1.1
Check: whether startup messages can be suppressed
Result: NOTE
    Please type into your browser:
    https://google.com/search?q=Warning%20messages:%0A%20r%20programming
    
    It looks like this package (or a package it requires) has a startup
    message which cannot be suppressed: see ?packageStartupMessage.
Flavors: [r-devel-linux-x86_64-debian-clang](https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-debian-clang/errorist-00check.html), [r-devel-linux-x86_64-debian-gcc](https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-debian-gcc/errorist-00check.html), [r-devel-linux-x86_64-fedora-clang](https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-fedora-clang/errorist-00check.html), [r-devel-linux-x86_64-fedora-gcc](https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-fedora-gcc/errorist-00check.html), [r-devel-windows-x86_64](https://www.r-project.org/nosvn/R.check/r-devel-windows-x86_64/errorist-00check.html)

Version: 0.1.1
Check: for missing documentation entries
Result: WARN
    Please type into your browser:
    https://google.com/search?q=Warning%20messages:%0A%20r%20programming
    All user-level objects in a package should have documentation entries.
    See chapter ‘Writing R documentation files’ in the ‘Writing R
    Extensions’ manual.
Flavors: [r-devel-linux-x86_64-debian-clang](https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-debian-clang/errorist-00check.html), [r-devel-linux-x86_64-debian-gcc](https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-debian-gcc/errorist-00check.html), [r-devel-linux-x86_64-fedora-clang](https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-fedora-clang/errorist-00check.html), [r-devel-linux-x86_64-fedora-gcc](https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-fedora-gcc/errorist-00check.html), [r-devel-windows-x86_64](https://www.r-project.org/nosvn/R.check/r-devel-windows-x86_64/errorist-00check.html)

Version: 0.1.1
Check: for code/documentation mismatches
Result: WARN
    Please type into your browser:
    https://google.com/search?q=Warning%20messages:%0A%20r%20programming
    Please type into your browser:
    https://google.com/search?q=Warning%20messages:%0A%20r%20programming
    Please type into your browser:
    https://google.com/search?q=Warning%20messages:%0A%20r%20programming
Flavors: [r-devel-linux-x86_64-debian-clang](https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-debian-clang/errorist-00check.html), [r-devel-linux-x86_64-debian-gcc](https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-debian-gcc/errorist-00check.html), [r-devel-linux-x86_64-fedora-clang](https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-fedora-clang/errorist-00check.html), [r-devel-linux-x86_64-fedora-gcc](https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-fedora-gcc/errorist-00check.html), [r-devel-windows-x86_64](https://www.r-project.org/nosvn/R.check/r-devel-windows-x86_64/errorist-00check.html)
@coatless
Copy link
Collaborator Author

coatless commented Nov 4, 2023

From Kurt, he suggested switching:

if (!is.null(last_warning_value)) {

To:

    if (!length(last_warning_value)) {

However, we're still seeing similar errors being triggered. More deeper investigation is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant