Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove from automatic configuration service-worker setup #59

Closed
coatless opened this issue Oct 1, 2023 · 2 comments
Closed

Remove from automatic configuration service-worker setup #59

coatless opened this issue Oct 1, 2023 · 2 comments
Labels
t: enhancement New feature or request

Comments

@coatless
Copy link
Owner

coatless commented Oct 1, 2023 •
edited

George advocated for switching the default communication channel from automatic to post-message before the 0.3.5 release, but we didn't have enough data. #31

Glancing at the comments made since then, this seems like the best way forward since we're not allowing for STDIN at the moment. Though, it may complicate things later down the line...
@coatless coatless changed the title Set default to post-message Remove from automatic configuration service-worker setup Oct 30, 2023
@coatless
Copy link
Owner Author

When the next version of webR is released, the default change is going to switch to using post-message instead of service-worker. This means we likely will want to update the Lua filter's automatic option and all the documentation.

Relevant PR:
r-wasm/webr#297

@coatless coatless added the t: enhancement New feature or request label Oct 30, 2023
@coatless
Copy link
Owner Author

Addressed in #96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
t: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@coatless