Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No documentation on function binding incompatibility #110

Closed
texonidas opened this issue Sep 30, 2019 · 1 comment
Closed

No documentation on function binding incompatibility #110

texonidas opened this issue Sep 30, 2019 · 1 comment

Comments

@texonidas
Copy link
Contributor

I will putting a pull request in in the next few hours, but for paper trail I will log the issue here first.

Currently the documentation contains no references to the distinction between AngularJS function bindings and React function props. AngularJS function bindings will invoke the expression when the function binding is called, whereas React will directly pass the values from the prop. In hindsight it is somewhat obvious, however I still think it bears stating explicitly in the readme that you need to set the binding/prop directly to the value of the function you are invoking.

There are a handful of issues people have logged in the past around this issue, so I think adding the distinction will be useful to prevent any confusion.

@ghost
Copy link

ghost commented Oct 2, 2019

👍 thanks for the PR

@ghost ghost closed this as completed Oct 2, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant