Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npx coauthors is slow..! We should remove zod in core #46

Open
manudeli opened this issue Apr 25, 2024 · 0 comments
Open

npx coauthors is slow..! We should remove zod in core #46

manudeli opened this issue Apr 25, 2024 · 0 comments
Assignees

Comments

@manudeli
Copy link
Member

manudeli commented Apr 25, 2024

In using npx, performance is more important than zod parsing runtimely
We can use just typescript type.

So I will remove below line

return res.json().then(githubUserSchema.parse);

@manudeli manudeli self-assigned this Apr 25, 2024
@manudeli manudeli changed the title npx coauthors is too slow..! We should remove zod in core npx coauthors is slow..! We should remove zod in core Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant